From: Shobhit Kumar <shobhit.kumar@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: drm/i915: Disable DDI Pipe Control on HSW while disabling pipe
Date: Fri, 8 Jun 2012 11:44:23 +0530 [thread overview]
Message-ID: <1339136063-29548-1-git-send-email-shobhit.kumar@intel.com> (raw)
In Haswell while disabling a pipe, we need to disable the DDI control as
well along with the PIPECONF. Otherwise we will hit assertions during crtc
disable
Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 0161d94..c69671d 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -1645,6 +1645,13 @@ static void intel_disable_pipe(struct drm_i915_private *dev_priv,
I915_WRITE(reg, val & ~PIPECONF_ENABLE);
intel_wait_for_pipe_off(dev_priv->dev, pipe);
+
+ /* On HSW DDI Pipe control has to be disabled as well */
+ if (IS_HASWELL(dev_priv->dev)) {
+ val = I915_READ(DDI_FUNC_CTL(pipe));
+ val = val & (~PIPE_DDI_FUNC_ENABLE);
+ I915_WRITE(DDI_FUNC_CTL(pipe), val);
+ }
}
/*
--
1.7.7.6
next reply other threads:[~2012-06-08 6:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 6:14 Shobhit Kumar [this message]
2012-06-08 12:49 ` drm/i915: Disable DDI Pipe Control on HSW while disabling pipe Daniel Vetter
2012-06-08 13:50 ` Eugeni Dodonov
2012-06-11 5:25 ` Shobhit Kumar
2012-06-11 7:08 ` Daniel Vetter
2012-06-11 8:27 ` Shobhit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339136063-29548-1-git-send-email-shobhit.kumar@intel.com \
--to=shobhit.kumar@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox