public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Eugeni Dodonov <eugeni.dodonov@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Eugeni Dodonov <eugeni.dodonov@intel.com>
Subject: [PATCH 3/7] drm/i915: support Haswell-style force waking
Date: Fri, 29 Jun 2012 11:43:49 -0300	[thread overview]
Message-ID: <1340981033-19461-4-git-send-email-eugeni.dodonov@intel.com> (raw)
In-Reply-To: <1340981033-19461-1-git-send-email-eugeni.dodonov@intel.com>

On Haswell, there is a different register for reading force wake ACKs.

v2: simplify forcewake dance and therefore the commit message as suggested by
Daniel Vetter.

Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 10 ++++++++--
 drivers/gpu/drm/i915/i915_reg.h |  1 +
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 3ef2103..cc8126e 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -474,16 +474,22 @@ static void __gen6_gt_force_wake_get(struct drm_i915_private *dev_priv)
 static void __gen6_gt_force_wake_mt_get(struct drm_i915_private *dev_priv)
 {
 	unsigned long timeout;
+	u32 forcewake_ack;
+
+	if (IS_HASWELL(dev_priv->dev))
+		forcewake_ack = FORCEWAKE_ACK_HSW;
+	else
+		forcewake_ack = FORCEWAKE_MT_ACK;
 
 	timeout = jiffies + msecs_to_jiffies(1);
-	while (I915_READ_NOTRACE(FORCEWAKE_MT_ACK) & 1 &&
+	while (I915_READ_NOTRACE(forcewake_ack) & 1 &&
 	       time_before(jiffies, timeout))
 		;
 
 	I915_WRITE_NOTRACE(FORCEWAKE_MT, _MASKED_BIT_ENABLE(1));
 
 	timeout = jiffies + msecs_to_jiffies(1);
-	while ((I915_READ_NOTRACE(FORCEWAKE_MT_ACK) & 1) == 0 &&
+	while ((I915_READ_NOTRACE(forcewake_ack) & 1) == 0 &&
 	       time_before(jiffies, timeout))
 		;
 
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 20f7f0d..f17de3d 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -4095,6 +4095,7 @@
 #define  FORCEWAKE				0xA18C
 #define  FORCEWAKE_VLV				0x1300b0
 #define  FORCEWAKE_ACK_VLV			0x1300b4
+#define  FORCEWAKE_ACK_HSW			0x130044
 #define  FORCEWAKE_ACK				0x130090
 #define  FORCEWAKE_MT				0xa188 /* multi-threaded */
 #define  FORCEWAKE_MT_ACK			0x130040
-- 
1.7.11.1

  parent reply	other threads:[~2012-06-29 14:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29 14:43 [PATCH 0/7] Haswell RC6 updates Eugeni Dodonov
2012-06-29 14:43 ` [PATCH 1/7] drm/i915: Group the GT routines together in both code and vtable Eugeni Dodonov
2012-06-29 14:43 ` [PATCH 2/7] drm/i915: Implement w/a for sporadic read failures on waking from rc6 Eugeni Dodonov
2012-06-29 14:43 ` Eugeni Dodonov [this message]
2012-06-29 14:43 ` [PATCH 4/7] drm/i915: add RPS configuration for Haswell Eugeni Dodonov
2012-06-29 14:50   ` Eugeni Dodonov
2012-06-29 15:01     ` Eugeni Dodonov
2012-06-29 16:45     ` Jesse Barnes
2012-06-29 14:43 ` [PATCH 5/7] drm/i915: disable RC6 when disabling rps Eugeni Dodonov
2012-06-29 14:43 ` [PATCH 6/7] drm/i915: introduce haswell_init_clock_gating Eugeni Dodonov
2012-06-29 14:43 ` [PATCH 7/7] drm/i915: enable RC6 workaround on Haswell Eugeni Dodonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340981033-19461-4-git-send-email-eugeni.dodonov@intel.com \
    --to=eugeni.dodonov@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox