From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 0/5] reset rework, 2nd try
Date: Wed, 04 Jul 2012 21:54:09 +0100 [thread overview]
Message-ID: <1341435312_170509@CP5-2952> (raw)
In-Reply-To: <1341433123-23055-1-git-send-email-daniel.vetter@ffwll.ch>
On Wed, 4 Jul 2012 22:18:38 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Hi all,
>
> I took me a while to see the real issues Chris has been complaining about, but I
> think the reworked patches take them all into account now. The big change is
> that the wedged check at the beginning of intel_ring_begin stays, but gets
> improved by properly deciding betweein -EIO and -EAGAIN. I've checked all the
> callsites and couldn't find any issues.
>
> Comments, flames, reviews and testing reports highly welcome.
Other than being dense and requiring a big loud comment explaining that
'EIO without !wedged' means an EIO emanating from another subsystem,
this looks good to me and more importantly survives battery from the
pathological renderer.
With the spelling mistakes fixed and an improved comment for the
SIGBUS patch,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Tested-by: Chris Wilson <chris@chris-wilson.co.uk>
The only last item on my wishlist for this series would be to capture
more of your discovery as code comments for next time...
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-07-04 20:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 20:18 [PATCH 0/5] reset rework, 2nd try Daniel Vetter
2012-07-04 20:18 ` [PATCH 1/5] drm/i915: don't trylock in the gpu reset code Daniel Vetter
2012-07-04 20:18 ` [PATCH 2/5] drm/i915: non-interruptible sleeps can't handle -EGAIN Daniel Vetter
2012-07-04 20:54 ` [PATCH] drm/i915: non-interruptible sleeps can't handle -EAGAIN Daniel Vetter
2012-07-04 20:18 ` [PATCH 3/5] drm/i915: don't hang userspace when the gpu reset is stuck Daniel Vetter
2012-07-04 20:18 ` [PATCH 4/5] drm/i915: properly SIGBUS on I/O errors Daniel Vetter
2012-07-04 20:40 ` Daniel Vetter
2012-07-04 20:18 ` [PATCH 5/5] drm/i915: don't return a spurious -EIO from intel_ring_begin Daniel Vetter
2012-07-04 20:52 ` [PATCH] " Daniel Vetter
2012-07-04 20:54 ` Chris Wilson [this message]
2012-07-05 8:04 ` [PATCH 0/5] reset rework, 2nd try Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341435312_170509@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).