public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Wang Xingchao <xingchao.wang@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: paulo.r.zanoni@intel.com
Subject: [PATCH v2 0/4] Haswell HDMI/DP audio enable
Date: Tue, 31 Jul 2012 10:47:01 +0800	[thread overview]
Message-ID: <1343702825-15439-1-git-send-email-xingchao.wang@intel.com> (raw)

This patch series enable HDMI audio on Haswell platform, not DP audio.
The DP enablement will come after the DP patches are upstream.

V2 patches fixed one warning and some type errors.

Here're some notes useful for you to test the patches on Sharkbay machine:
I> please make sure your branch include below three patches in Takashi's 
sound tree, othersiwe there's no proper Haswell ID and HDMI ID.  
http://git.alsa-project.org/?p=alsa-kmirror.git;a=commitdiff;h=79fc901301d6115b11457e8240ed6abc4b3f5c65
http://git.alsa-project.org/?p=alsa-kmirror.git;a=commitdiff;h=e269cee227a2b2297b79bfc71094c709b9387061
http://git.alsa-project.org/?p=alsa-kmirror.git;a=commitdiff;h=cb192625233496ac3d96cce667ebf4e322dab678

II> No sound from HDMI/DP.
we found it's not stable in current stage, sometimes you may not heard sound
from HDMI or DP port, but most of the time you can heard clear sound. After
some investigation, we suspect the HDA verb didnot really make codec 
change,and we regard the GPU register as the right one.
the easy way is to use intel_audio_dump to compare related registers, and make
sure the port is enabled and unmute, otherwise there's no sound.
intel_audio_tools has no support on Haswell yet, i wrote patches to make that
happen, if you need the patches, please feel free to let me know. Here's part
of the snapshot about port enable and mute status from intel_audio_dump:

AUD_PORT_EN_HD_CFG  Port_B_Out_Enable			1
AUD_PORT_EN_HD_CFG  Port_C_Out_Enable			1
AUD_PORT_EN_HD_CFG  Port_D_Out_Enable			1
AUD_PORT_EN_HD_CFG  Port_B_Amp_Mute_Status		1
AUD_PORT_EN_HD_CFG  Port_C_Amp_Mute_Status		0
AUD_PORT_EN_HD_CFG  Port_D_Amp_Mute_Status		1

you can see from above message, the Port C is enabled and unmute, that's what
we expect.

Wang Xingchao (4):
  drm/i915: HSW audio registers definition
  drm/i915: write eld info for HDMI audio
  drm/i915: Haswell HDMI audio enable
  ALSA HDA: Force HDMI pins enabled

 drivers/gpu/drm/i915/i915_reg.h      |   46 +++++++++++++++++++++++++++
 drivers/gpu/drm/i915/intel_ddi.c     |    6 +++-
 drivers/gpu/drm/i915/intel_display.c |   58 ++++++++++++++++++++++++++++++++++
 sound/pci/hda/patch_hdmi.c           |   15 +++++----
 4 files changed, 117 insertions(+), 8 deletions(-)

-- 
1.7.9.5

             reply	other threads:[~2012-07-31  2:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-31  2:47 Wang Xingchao [this message]
2012-07-31  2:47 ` [PATCH V2 1/4] drm/i915: HSW audio registers definition Wang Xingchao
2012-07-31  2:47 ` [PATCH V2 2/4] drm/i915: write eld info for HDMI audio Wang Xingchao
2012-07-31  2:47 ` [PATCH V2 3/4] drm/i915: Haswell HDMI audio enable Wang Xingchao
2012-08-02  2:12   ` Paulo Zanoni
2012-08-06  7:07     ` Daniel Vetter
2012-08-06 10:10       ` Wang, Xingchao
2012-07-31  2:47 ` [PATCH V2 4/4] ALSA HDA: Force HDMI pins enabled Wang Xingchao
2012-07-31 11:18   ` Takashi Iwai
2012-08-01  0:27     ` Wang, Xingchao
2012-08-01  5:55       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343702825-15439-1-git-send-email-xingchao.wang@intel.com \
    --to=xingchao.wang@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox