From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH 2/4] drm/i915: don't disable fdi links harder in ilk_crtc_enable
Date: Thu, 6 Sep 2012 22:08:33 +0200 [thread overview]
Message-ID: <1346962115-7267-3-git-send-email-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <1346962115-7267-1-git-send-email-daniel.vetter@ffwll.ch>
Because they should have been disabled when shutting down the display
pipe previously. To ensure that this is the case, add a few assserts
instead of unconditionally disabling the fdi link.
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/intel_display.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 6c06109..0973797 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3182,10 +3182,12 @@ static void ironlake_crtc_enable(struct drm_crtc *crtc)
is_pch_port = intel_crtc_driving_pch(crtc);
- if (is_pch_port)
+ if (is_pch_port) {
ironlake_fdi_pll_enable(intel_crtc);
- else
- ironlake_fdi_disable(crtc);
+ } else {
+ assert_fdi_tx_disabled(dev_priv, pipe);
+ assert_fdi_rx_disabled(dev_priv, pipe);
+ }
/* Enable panel fitting for LVDS */
if (dev_priv->pch_pf_size &&
--
1.7.11.2
next prev parent reply other threads:[~2012-09-06 21:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 20:08 [PATCH 0/4] some follow-up fixlets from the modeset rework Daniel Vetter
2012-09-06 20:08 ` [PATCH 1/4] drm/i915: rip out intel_disable_pch_ports Daniel Vetter
2012-09-13 20:37 ` Jesse Barnes
2012-09-06 20:08 ` Daniel Vetter [this message]
2012-09-13 20:38 ` [PATCH 2/4] drm/i915: don't disable fdi links harder in ilk_crtc_enable Jesse Barnes
2012-09-06 20:08 ` [PATCH 3/4] drm/i915: don't call dpms funcs after set_mode Daniel Vetter
2012-09-13 20:41 ` Jesse Barnes
2012-09-06 20:08 ` [PATCH 4/4] drm/i915: update dpms property in set_mode Daniel Vetter
2012-09-13 20:42 ` Jesse Barnes
2012-09-14 21:38 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346962115-7267-3-git-send-email-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox