Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 0/8] Rework ironlake_crtc_mode_set
Date: Wed, 12 Sep 2012 10:06:28 -0300	[thread overview]
Message-ID: <1347455196-5167-1-git-send-email-przanoni@gmail.com> (raw)

From: Paulo Zanoni <paulo.r.zanoni@intel.com>

Every time I have to change ironlake_crtc_mode_set I get scared by the
fact that it has 404 lines. I feel way more confident when I'm changing
small functions that do specific self-contained things.

Thus, the goal of this patch series is to extract from
ironlake_crtc_mode_set sub-functions that do specific things. The goal
of the series is to only change the coding style, not changing the
functionality.

The order that code executes was slightly changed in a few cases, but I
don't expect this to break anything. I tested this series on a SNB with
LVDS, HDMI, DP and VGA and everything worked. I don't have access to
more machines right now, but once I get to my office again I will test
more.

Also, I did a quick check on i9xx_crtc_mode_set and concluded we won't
be able to reuse any of the ironlake functions on it, although we can
try to split i9xx_crtc_mode_set in a similar way. Still, I'm not sure we
want to do that.

After these changes I'll be able to properly and sanely fix the
Haswell/LPT case (since Haswell/LPT is currently running
ironlake_crtc_mode_set):
  - fork a haswell_crtc_mode_set function
  - create haswell-specific versions of functions that should be
    different on Haswell
  - run IBX/CPT-specific code only on IBX/CPT, same for LPT

Paulo Zanoni (8):
  drm/i915: extract ironlake_set_pipeconf form ironlake_crtc_mode_set
  drm/i915: extract LVDS-specific code from ironlake_crtc_mode_set
  drm/i915: extract set_pipe_timings from ironlake_crtc_mode_set
  drm/i915: simplify setting DSPCNTR inside ironlake_crtc_mode_set
  drm/i915: extract set_m_n from ironlake_crtc_mode_set
  drm/i915: extract compute_clocks from ironlake_crtc_mode_set
  drm/i915: extract pch_pll_set from ironlake_crtc_mode_set
  drm/i915: remove unused variables from ironlake_crtc_mode_set

 drivers/gpu/drm/i915/intel_display.c |  575 +++++++++++++++++++---------------
 drivers/gpu/drm/i915/intel_drv.h     |    3 +
 drivers/gpu/drm/i915/intel_lvds.c    |   43 +++
 3 files changed, 374 insertions(+), 247 deletions(-)

-- 
1.7.10.4

             reply	other threads:[~2012-09-12 13:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12 13:06 Paulo Zanoni [this message]
2012-09-12 13:06 ` [PATCH 1/8] drm/i915: extract ironlake_set_pipeconf form ironlake_crtc_mode_set Paulo Zanoni
2012-09-12 14:03   ` Daniel Vetter
2012-09-12 13:06 ` [PATCH 2/8] drm/i915: extract LVDS-specific code from ironlake_crtc_mode_set Paulo Zanoni
2012-09-12 13:56   ` Daniel Vetter
2012-09-12 13:06 ` [PATCH 3/8] drm/i915: extract set_pipe_timings " Paulo Zanoni
2012-09-12 14:11   ` Daniel Vetter
2012-09-19 18:11     ` Paulo Zanoni
2012-09-20  7:32       ` Daniel Vetter
2012-09-12 13:06 ` [PATCH 4/8] drm/i915: simplify setting DSPCNTR inside ironlake_crtc_mode_set Paulo Zanoni
2012-09-12 14:12   ` Daniel Vetter
2012-09-12 13:06 ` [PATCH 5/8] drm/i915: extract set_m_n from ironlake_crtc_mode_set Paulo Zanoni
2012-09-12 14:20   ` Daniel Vetter
2012-09-12 13:06 ` [PATCH 6/8] drm/i915: extract compute_clocks " Paulo Zanoni
2012-09-12 14:31   ` Daniel Vetter
2012-09-12 14:34     ` Daniel Vetter
2012-09-12 13:06 ` [PATCH 7/8] drm/i915: extract pch_pll_set " Paulo Zanoni
2012-09-12 14:40   ` Daniel Vetter
2012-09-18 20:18     ` Paulo Zanoni
2012-09-19  9:17       ` Daniel Vetter
2012-09-12 13:06 ` [PATCH 8/8] drm/i915: remove unused variables " Paulo Zanoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347455196-5167-1-git-send-email-przanoni@gmail.com \
    --to=przanoni@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox