From: Imre Deak <imre.deak@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [i-g-t PATCH 4/4] flip_test: switch to using monotonic timestamps
Date: Thu, 22 Nov 2012 16:07:32 +0200 [thread overview]
Message-ID: <1353593252.11370.5.camel@localhost> (raw)
In-Reply-To: <CAKMK7uF8v1S9oO+9-OKrxytk4y0Eb6K9DqkWrkB=yr=Jv4XVkA@mail.gmail.com>
On Thu, 2012-11-22 at 15:04 +0100, Daniel Vetter wrote:
> On Thu, Nov 22, 2012 at 2:50 PM, Imre Deak <imre.deak@intel.com> wrote:
> >> > + enable_monotonic_timestamp(!(flags & TEST_TIMESTAMP_REAL));
> >>
> >> I don't follow why we should enable monotonic timestamps for some tests
> >> and not for some others? Shouldn't all tests with TEST_CHECK_TS just use
> >> the same clock the kernel uses?
> >
> > The idea was to also test the compatibility mode, where we get real
> > timestamps.
>
> Oh, I've missed that you write back the desired value. I don't think
> we need to test the compat mode if it's not enabled, just test
> whatever mode is enabled. That way we also check whether the getcap
> interface works.
Ok, will do so. We have to wait though until DRM_CAP_TIMESTAMP_MONOTONIC
is added to libdrm. I've sent already a patch for this.
--Imre
next prev parent reply other threads:[~2012-11-22 14:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 13:25 [i-g-t PATCH 0/4] flip_test: support for monotonic timestamps Imre Deak
2012-11-22 13:25 ` [i-g-t PATCH 1/4] flip_test: add wf-vblank test for expired sequence Imre Deak
2012-11-22 13:25 ` [i-g-t PATCH 2/4] flip_test: skip check for last_received_ts for the first event Imre Deak
2012-11-22 13:25 ` [i-g-t PATCH 3/4] flip_test: use monotonic time to measure the test duration Imre Deak
2012-11-22 13:52 ` Daniel Vetter
2012-11-22 13:25 ` [i-g-t PATCH 4/4] flip_test: switch to using monotonic timestamps Imre Deak
2012-11-22 13:46 ` Daniel Vetter
2012-11-22 13:50 ` Imre Deak
2012-11-22 14:04 ` Daniel Vetter
2012-11-22 14:07 ` Imre Deak [this message]
2012-11-22 14:46 ` [i-g-t PATCH 4/4] flip_test: switch to using monotonic timestamps (v2) Imre Deak
2012-11-22 20:20 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353593252.11370.5.camel@localhost \
--to=imre.deak@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox