From: ville.syrjala@linux.intel.com
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 1/3] drm/i915: Wake up pending_flip_queue as part of reset handling
Date: Fri, 15 Feb 2013 17:07:44 +0200 [thread overview]
Message-ID: <1360940866-22435-2-git-send-email-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <1360940866-22435-1-git-send-email-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Someone may be waiting for a flip that will never complete due to a GPU
reset. Wake up all such waiters after the GPU reset processing has
finished.
v2: Dropped the wake_up_all() from i915_handle_error() since
we no longer wait for pending flips with struct_mutex held.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/i915_irq.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 2cd97d1..672816a 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -915,6 +915,8 @@ static void i915_error_work_func(struct work_struct *work)
for_each_ring(ring, dev_priv, i)
wake_up_all(&ring->irq_queue);
+ wake_up_all(&dev_priv->pending_flip_queue);
+
wake_up_all(&dev_priv->gpu_error.reset_queue);
}
}
--
1.7.12.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2013-02-15 15:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 15:07 [PATCH 0/3] drm/i915: More page flip vs. reset improvements ville.syrjala
2013-02-15 15:07 ` ville.syrjala [this message]
2013-02-15 23:53 ` [PATCH v2 1/3] drm/i915: Wake up pending_flip_queue as part of reset handling Chris Wilson
2013-02-18 9:58 ` Ville Syrjälä
2013-02-18 12:41 ` Ville Syrjälä
2013-02-18 15:31 ` Ville Syrjälä
2013-02-18 16:39 ` Daniel Vetter
2013-02-15 15:07 ` [PATCH v2 2/3] drm/i915: Really wait for pending flips when panning ville.syrjala
2013-02-15 15:07 ` [PATCH 3/3] drm/i915: Update primary planes after a GPU reset ville.syrjala
2013-02-15 15:28 ` Chris Wilson
2013-02-15 16:56 ` Ville Syrjälä
2013-02-15 23:47 ` Chris Wilson
2013-02-18 10:15 ` Ville Syrjälä
2013-02-18 10:47 ` Chris Wilson
2013-02-18 11:50 ` Ville Syrjälä
2013-02-18 12:08 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360940866-22435-2-git-send-email-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox