From: Bryce Harrington <bryce@canonical.com>
To: intel-gfx@lists.freedesktop.org, chris@chris-wilson.co.uk
Cc: Bryce Harrington <bryce@canonical.com>
Subject: [PATCH 8/8] xfree86: Also handle EAGAIN errors from drmSetInterfaceVersion().
Date: Fri, 15 Mar 2013 11:02:58 -0700 [thread overview]
Message-ID: <1363370578-30443-9-git-send-email-bryce@canonical.com> (raw)
In-Reply-To: <1363370578-30443-1-git-send-email-bryce@canonical.com>
It has been suggested that the kernel may pass EAGAIN when the device is
unavailable. This hasn't been seen in practice, and examination of the
function definition in libdrm suggests EAGAIN is handled internally so
would not be seen by the xserver when making this call. So, this patch
is probably unneeded. But include support anyway.
Signed-off-by: Bryce Harrington <bryce@canonical.com>
---
hw/xfree86/os-support/linux/lnx_platform.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/xfree86/os-support/linux/lnx_platform.c b/hw/xfree86/os-support/linux/lnx_platform.c
index 3386b67..b05719d 100644
--- a/hw/xfree86/os-support/linux/lnx_platform.c
+++ b/hw/xfree86/os-support/linux/lnx_platform.c
@@ -46,6 +46,9 @@ get_drm_info(struct OdevAttributes *attribs, char *path)
} if (err == -EACCES) {
if (tries % 500 == 0)
LogMessage(X_INFO, "waiting on drm device...\n");
+ } if (err == -EAGAIN) {
+ if (tries % 500 == 0)
+ LogMessage(X_INFO, "drm device busy...\n");
} else {
break;
}
--
1.7.9.5
prev parent reply other threads:[~2013-03-15 18:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 18:02 [PATCH 0/8] Handle drm race condition Bryce Harrington
2013-03-15 18:02 ` [PATCH 1/8] xfree86: (Cleanup) Close fd if drm interface 1.4 could not be set Bryce Harrington
2013-03-15 18:02 ` [PATCH 2/8] xfree86: Track error code and add label for error handling Bryce Harrington
2013-03-15 18:02 ` [PATCH 3/8] xfree86: Provide more details on failure Bryce Harrington
2013-03-15 18:02 ` [PATCH 4/8] xfree86: Keep trying to set interface on drm until it succeeds Bryce Harrington
2013-03-15 18:02 ` [PATCH 5/8] xfree86: After 2 sec, abort setting drm interface version Bryce Harrington
2013-03-18 11:00 ` Chris Wilson
2013-03-18 20:52 ` Bryce Harrington
2013-03-15 18:02 ` [PATCH 6/8] xfree86: Fix race condition failure opening drm Bryce Harrington
2013-03-15 18:02 ` [PATCH 7/8] xfree86: Be verbose if waiting on opening the drm device Bryce Harrington
2013-03-15 18:02 ` Bryce Harrington [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363370578-30443-9-git-send-email-bryce@canonical.com \
--to=bryce@canonical.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox