Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Dave Airlie <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm: prime: fix lookup of existing imports for self imported buffers
Date: Thu, 11 Apr 2013 12:24:55 +0300	[thread overview]
Message-ID: <1365672295.2476.3.camel@intelbox> (raw)
In-Reply-To: <CAPM=9txTNOhiKbE=mmwWoRvw-zcrYAyq+GRPRcxmiXKQLmVg=A@mail.gmail.com>

On Wed, 2013-04-10 at 07:52 +1000, Dave Airlie wrote:
> > Since atm we don't take a reference on the dma buf pointer when we add
> > it to the import lookup table the dma buf can vanish leaving the stale
> > pointer behind. This can in turn lead to returning stale GEM handles
> > when userspace imports a newly exported buffer.
> 
> 
> I sent a bunch of patches to prime months ago, maybe go back and dig them out
> 
> they might fix some of these issues,
> 
> I think danvet bikeshedded my will to care at the time due to lack of
> proper locking,
> the fact is the patches didn't change the locking, but I could
> probably go back and find them.
> 
> Hopefully you haven't gone and reinvented that work.

Yes, I checked it with the i-g-t/prime_self_import test case and it's
passing with your

"drm/prime: keep a reference from the handle to exported dma-buf (v2.1)"

patch, so we can drop this one.

--Imre

      reply	other threads:[~2013-04-11  9:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-09 12:08 [PATCH 1/2] drm: prime: fix refcounting on the dmabuf import error path Imre Deak
2013-04-09 12:08 ` [PATCH 2/2] drm: prime: fix lookup of existing imports for self imported buffers Imre Deak
2013-04-09 21:52   ` Dave Airlie
2013-04-11  9:24     ` Imre Deak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365672295.2476.3.camel@intelbox \
    --to=imre.deak@intel.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox