Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [i-g-t PATCH] tests/gem_wait_render_timeout: make sure the GPU is idle before exiting
Date: Mon, 27 May 2013 18:42:42 +0300	[thread overview]
Message-ID: <1369669362-21300-1-git-send-email-imre.deak@intel.com> (raw)

Leaving the GPU running after we exit can mess up timing dependent tests
we run afterwards.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64270

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 tests/gem_wait_render_timeout.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/gem_wait_render_timeout.c b/tests/gem_wait_render_timeout.c
index 14482e3..9ec4e49 100644
--- a/tests/gem_wait_render_timeout.c
+++ b/tests/gem_wait_render_timeout.c
@@ -216,6 +216,11 @@ int main(int argc, char **argv)
 	assert(gem_bo_wait_timeout(fd, dst2->handle, &timeout) == -ETIME);
 	assert(timeout == 0);
 
+	/* Make sure we exit only after the GPU is idle. Apply some fuzz
+	 * to the timeout since the calibrated iteration count can be
+	 * twice the amount the GPU can execute in a second. */
+	timeout = 5 * ENOUGH_WORK_IN_SECONDS * NSEC_PER_SEC;
+	assert(gem_bo_wait_timeout(fd, dst2->handle, &timeout) == 0);
 
 	if (do_signals)
 		drmtest_stop_signal_helper();
-- 
1.8.1.2

             reply	other threads:[~2013-05-27 15:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-27 15:42 Imre Deak [this message]
2013-05-28  9:31 ` [i-g-t PATCH] tests/gem_wait_render_timeout: make sure the GPU is idle before exiting Daniel Vetter
2013-05-28 14:22 ` [i-g-t PATCH v2 1/2] lib: make sure all rings are idle in gpu_quiescent_gpu() Imre Deak
2013-05-28 14:22 ` [i-g-t PATCH v2 2/2] tests/lib: make sure the GPU is idle at test start and exit Imre Deak
2013-05-28 14:35   ` [i-g-t PATCH v3 " Imre Deak
2013-05-28 16:33     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369669362-21300-1-git-send-email-imre.deak@intel.com \
    --to=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox