public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 5/6] drm/i915: POSTING_READ(DEIER) on ivybridge_irq_handler
Date: Thu,  4 Jul 2013 17:21:10 -0300	[thread overview]
Message-ID: <1372969271-3814-6-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1372969271-3814-1-git-send-email-przanoni@gmail.com>

From: Paulo Zanoni <paulo.r.zanoni@intel.com>

We have this POSTING_READ inside ironlake_irq_handler. I suppose we
also want it on IVB because we want to stop the IRQ handler as soon as
possible at this point. Also, I'll add ILK/SNB support to
ivybridge_irq_handler on the next patch.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 0aa784b..5cf8b07 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -1287,6 +1287,7 @@ static irqreturn_t ivybridge_irq_handler(int irq, void *arg)
 	/* disable master interrupt before clearing iir  */
 	de_ier = I915_READ(DEIER);
 	I915_WRITE(DEIER, de_ier & ~DE_MASTER_IRQ_CONTROL);
+	POSTING_READ(DEIER);
 
 	/* Disable south interrupts. We'll only write to SDEIIR once, so further
 	 * interrupts will will be stored on its back queue, and then we'll be
-- 
1.8.1.2

  parent reply	other threads:[~2013-07-04 20:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-04 20:21 [PATCH 0/6] ILK/IVB irq handler merge Paulo Zanoni
2013-07-04 20:21 ` [PATCH 1/6] drm/i915: extract ilk_display_irq_handler Paulo Zanoni
2013-07-04 20:21 ` [PATCH 2/6] drm/i915: extract ivb_display_irq_handler Paulo Zanoni
2013-07-04 20:21 ` [PATCH 3/6] drm/i915: don't read or write GEN6_PMIIR on Gen 5 Paulo Zanoni
2013-07-04 20:21 ` [PATCH 4/6] drm/i915: reorganize ironlake_irq_handler Paulo Zanoni
2013-07-04 20:21 ` Paulo Zanoni [this message]
2013-07-04 20:21 ` [PATCH 6/6] drm/i915: add ILK/SNB support to ivybridge_irq_handler Paulo Zanoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372969271-3814-6-git-send-email-przanoni@gmail.com \
    --to=przanoni@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox