From: Ben Widawsky <ben@bwidawsk.net>
To: Intel GFX <intel-gfx@lists.freedesktop.org>
Cc: Ben Widawsky <ben@bwidawsk.net>
Subject: [PATCH 3/9] Revert "drm/i915: Use gtt_space->start for stolen reservation"
Date: Fri, 5 Jul 2013 14:41:01 -0700 [thread overview]
Message-ID: <1373060467-896-3-git-send-email-ben@bwidawsk.net> (raw)
In-Reply-To: <1373060467-896-1-git-send-email-ben@bwidawsk.net>
This reverts commit 7dedae28b41000539b6c18bcf72107c97e4937e4.
Conflicts:
drivers/gpu/drm/i915/i915_drv.h
---
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
drivers/gpu/drm/i915/i915_gem_stolen.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index bd676df..c2d2f90 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1201,7 +1201,7 @@ enum hdmi_force_audio {
HDMI_AUDIO_ON, /* force turn on HDMI audio */
};
-#define I915_GTT_RESERVED (ULONG_MAX)
+#define I915_GTT_RESERVED ((struct drm_mm_node *)0x1)
#define I915_GTT_OFFSET_NONE ((u32)-1)
struct drm_i915_gem_object_ops {
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 7f85d6f..66929ea 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -632,7 +632,7 @@ void i915_gem_setup_global_gtt(struct drm_device *dev,
DRM_DEBUG_KMS("reserving preallocated space: %x + %zx\n",
obj->gtt_offset, obj->base.size);
- BUG_ON(obj->gtt_space->start != I915_GTT_RESERVED);
+ BUG_ON(obj->gtt_space != I915_GTT_RESERVED);
obj->gtt_space = drm_mm_create_block(&dev_priv->mm.gtt_space,
obj->gtt_offset,
obj->base.size,
diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c
index 4bb2ccd..aea6221 100644
--- a/drivers/gpu/drm/i915/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
@@ -398,7 +398,7 @@ i915_gem_object_create_stolen_for_preallocated(struct drm_device *dev,
return NULL;
}
} else
- obj->gtt_space->start = I915_GTT_RESERVED;
+ obj->gtt_space = I915_GTT_RESERVED;
obj->gtt_offset = gtt_offset;
obj->has_global_gtt_mapping = 1;
--
1.8.3.2
next prev parent reply other threads:[~2013-07-05 21:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 21:40 [PATCH 1/9] Revert "drm/i915: Getter/setter for object attributes" Ben Widawsky
2013-07-05 21:41 ` [PATCH 2/9] Revert "drm/i915: Kill obj->gtt_offset" Ben Widawsky
2013-07-05 21:41 ` Ben Widawsky [this message]
2013-07-05 21:41 ` [PATCH 4/9] drm: pre allocate node for create_block Ben Widawsky
2013-07-05 21:41 ` [PATCH 5/9] drm: Change create block to reserve node Ben Widawsky
2013-07-05 21:41 ` [PATCH 6/9] drm/i915: Getter/setter for object attributes Ben Widawsky
2013-07-05 21:41 ` [PATCH 7/9] drm/i915: Kill obj->gtt_offset Ben Widawsky
2013-07-05 21:41 ` [PATCH 8/9] drm/i915: Embed drm_mm_node in i915 gem obj Ben Widawsky
2013-07-05 22:07 ` Daniel Vetter
2013-07-05 21:41 ` [PATCH 9/9] drm: Optionally create mm blocks from top-to-bottom Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373060467-896-3-git-send-email-ben@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox