From: Chuansheng Liu <chuansheng.liu@intel.com>
To: daniel.vetter@ffwll.ch, airlied@linux.ie
Cc: intel-gfx@lists.freedesktop.org, chuansheng.liu@intel.com,
fei.li@intel.com, dri-devel@lists.freedesktop.org
Subject: [PATCH] drm/i915: Sync the hotplug work when device suspending
Date: Sun, 28 Jul 2013 01:43:02 +0800 [thread overview]
Message-ID: <1374946982.28551.4.camel@cliu38-desktop-build> (raw)
It is possible that during i915 device suspending with one pending
hotplug work, one of cases is the device resume/suspend quickly.
At this case, the hotplug work will be executed even after device
is OFF, in Intel Android platform, it will cause system hang.
Here we need sync the hotplug work in function i915_drm_freeze().
Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com>
Signed-off-by: Li Fei <fei.li@intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 45b3c03..95c6956 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -562,6 +562,8 @@ static int i915_drm_freeze(struct drm_device *dev)
drm_irq_uninstall(dev);
dev_priv->enable_hotplug_processing = false;
+ cancel_work_sync(&dev_priv->hotplug_work);
+
/*
* Disable CRTCs directly since we want to preserve sw state
* for _thaw.
--
1.7.9.5
next reply other threads:[~2013-07-27 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-27 17:43 Chuansheng Liu [this message]
2013-07-27 9:40 ` [PATCH] drm/i915: Sync the hotplug work when device suspending Chris Wilson
2013-07-27 10:10 ` Liu, Chuansheng
2013-08-05 5:42 ` [Intel-gfx] " Daniel Vetter
2013-08-06 1:00 ` Liu, Chuansheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374946982.28551.4.camel@cliu38-desktop-build \
--to=chuansheng.liu@intel.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fei.li@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox