public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: Use frame counter for intel_wait_for_vblank() on CTG
Date: Thu, 07 Nov 2013 18:39:37 +0200	[thread overview]
Message-ID: <1383842377.2445.1.camel@ideak-mobl> (raw)
In-Reply-To: <1383753389-12763-5-git-send-email-rodrigo.vivi@gmail.com>

On Wed, 2013-11-06 at 13:56 -0200, Rodrigo Vivi wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Use the same wait_for_vblank code for CTG that we use for ILK+.
> 
> Also fix the name of the frame counter register while at it.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_display.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 64390f3..7595d5a 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -748,10 +748,10 @@ enum transcoder intel_pipe_to_cpu_transcoder(struct drm_i915_private *dev_priv,
>  	return intel_crtc->config.cpu_transcoder;
>  }
>  
> -static void ironlake_wait_for_vblank(struct drm_device *dev, int pipe)
> +static void g4x_wait_for_vblank(struct drm_device *dev, int pipe)
>  {
>  	struct drm_i915_private *dev_priv = dev->dev_private;
> -	u32 frame, frame_reg = PIPEFRAME(pipe);
> +	u32 frame, frame_reg = PIPE_FRMCOUNT_GM45(pipe);
>  
>  	frame = I915_READ(frame_reg);
>  
> @@ -772,8 +772,8 @@ void intel_wait_for_vblank(struct drm_device *dev, int pipe)
>  	struct drm_i915_private *dev_priv = dev->dev_private;
>  	int pipestat_reg = PIPESTAT(pipe);
>  
> -	if (INTEL_INFO(dev)->gen >= 5) {
> -		ironlake_wait_for_vblank(dev, pipe);
> +	if (IS_G4X(dev) || INTEL_INFO(dev)->gen >= 5) {
> +		g4x_wait_for_vblank(dev, pipe);
>  		return;
>  	}
>  


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2013-11-07 16:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-06 15:56 [PATCH 0/5] drm-intel-collector - update Rodrigo Vivi
2013-11-06 15:56 ` [PATCH 1/5] drm/i915: Asynchronously perform the set-base for a simple modeset Rodrigo Vivi
2013-11-06 15:56 ` [PATCH 2/5] drm/i915: Initialise min/max frequencies before updating RPS registers Rodrigo Vivi
2013-11-07 17:43   ` Ville Syrjälä
2013-11-07 18:13     ` Daniel Vetter
2013-11-06 15:56 ` [PATCH 3/5] drm/i915: Fix gen3/4 vblank counter wraparound Rodrigo Vivi
2013-11-07 16:16   ` Imre Deak
2013-11-07 16:20     ` Daniel Vetter
2013-11-06 15:56 ` [PATCH 4/5] drm/i915: Use frame counter for intel_wait_for_vblank() on CTG Rodrigo Vivi
2013-11-07 16:39   ` Imre Deak [this message]
2013-11-06 15:56 ` [PATCH 5/5] drm/i915: Require HW contexts (when possible) Rodrigo Vivi
2013-11-07  8:35   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383842377.2445.1.camel@ideak-mobl \
    --to=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox