public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Xiang, Haihao" <haihao.xiang@intel.com>
To: ykzhao <yakui.zhao@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel gfx][i-g-t PATCH 4/4] tests/gem_media_fill: the assembly code for the shader used in the case
Date: Mon, 02 Dec 2013 09:02:20 +0800	[thread overview]
Message-ID: <1385946140.6449.55.camel@xhh-ivb32> (raw)
In-Reply-To: <1385710607.2109.1.camel@genxdev-ykzhao.sh.intel.com>

> On Thu, 2013-11-28 at 23:57 -0700, Xiang, Haihao wrote:
> > From: "Xiang, Haihao" <haihao.xiang@intel.com>
> > 
> > The code is for reference only
> > 
> > Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
> > ---
> >  shaders/media/README         |    6 ++++++
> >  shaders/media/media_fill.gxa |   30 ++++++++++++++++++++++++++++++
> >  2 files changed, 36 insertions(+)
> >  create mode 100644 shaders/media/README
> >  create mode 100644 shaders/media/media_fill.gxa
> > 
> > diff --git a/shaders/media/README b/shaders/media/README
> > new file mode 100644
> > index 0000000..334106c
> > --- /dev/null
> > +++ b/shaders/media/README
> > @@ -0,0 +1,6 @@
> > +These files are here for reference only.
> > +
> > +Commands used to generate the shader on gen8
> > +$> m4 media_fill.gxa > media_fill.gxm
> > +$> intel-gen4asm -g 8 -o <output> media_fill.gxm
> > +
> > diff --git a/shaders/media/media_fill.gxa b/shaders/media/media_fill.gxa
> > new file mode 100644
> > index 0000000..d2931d4
> > --- /dev/null
> > +++ b/shaders/media/media_fill.gxa
> > @@ -0,0 +1,30 @@
> > +/*
> > + * Registers
> > + * g0 -- header
> > + * g1 -- constant
> > + * g2 -- inline data
> > + * g3 -- reserved
> > + * g4-g12 message payload
> > + */
> > +define(`ORIG',          `g2.0<2,2,1>UD')
> > +define(`COLOR',         `g1.0')
> > +define(`COLORUB',       `COLOR<0,1,0>UB')
> > +define(`COLORUD',       `COLOR<0,1,0>UD')
> > +
> > +mov(4)  COLOR<1>UB      COLORUB         {align1};
> > +
> > +/* WRITE */
> > +mov(8)  g4.0<1>UD       g0.0<8,8,1>UD   {align1};
> > +mov(2)  g4.0<1>UD       ORIG            {align1};
> > +mov(1)  g4.8<1>UD       0x000f000fUD    {align1};
> > +
> > +mov(16) g5.0<1>UD       COLORUD         {align1 compr};
> > +mov(16) g7.0<1>UD       COLORUD         {align1 compr};
> > +mov(16) g9.0<1>UD       COLORUD         {align1 compr};
> > +mov(16) g11.0<1>UD      COLORUD         {align1 compr};
> > +
> > +send(16) 4 acc0<1>UW null write(0, 0, 10, 0) mlen 9 rlen 0 {align1};
> > +
> > +/* EOT */
> > +mov(8)  g4.0<1>UD       g0.0<8,8,1>UD   {align1};
> > +send(16) 4 acc0<1>UW null thread_spawner(0, 0, 1) mlen 1 rlen 0 {align1 EOT};
> 
> Based on the spec the send with EOT flag should use the register space
> r112-r127 for <src>. So 4 had better be changed as 127.

Thanks for pointing out the issue, I will fix it in the new version of
patches.


> 
> Thanks.
>     Yakui
> 
> 

  reply	other threads:[~2013-12-02  1:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-29  6:57 [Intel gfx][i-g-t PATCH 1/4] tests: add gem_media_fill Xiang, Haihao
2013-11-29  6:57 ` [Intel gfx][i-g-t PATCH 2/4] tests/gem_media_fill: add support for gen8 Xiang, Haihao
2013-11-29  6:57 ` [Intel gfx][i-g-t PATCH 3/4] tests/gem_media_fill: add support for gen7 Xiang, Haihao
2013-11-29  6:57 ` [Intel gfx][i-g-t PATCH 4/4] tests/gem_media_fill: the assembly code for the shader used in the case Xiang, Haihao
2013-11-29  7:36   ` ykzhao
2013-12-02  1:02     ` Xiang, Haihao [this message]
2013-11-29  8:02 ` [Intel gfx][i-g-t PATCH 1/4] tests: add gem_media_fill Daniel Vetter
2013-12-02  1:06   ` Xiang, Haihao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385946140.6449.55.camel@xhh-ivb32 \
    --to=haihao.xiang@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox