From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org
Subject: [PATCH] tests/gem_evict_everything: Use bo_count instead of count where intended
Date: Fri, 6 Dec 2013 11:37:49 +0000 [thread overview]
Message-ID: <1386329869-12379-1-git-send-email-tvrtko.ursulin@linux.intel.com> (raw)
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Don't see that it causes a problem but it looks it was intended
to use bo_count at these places.
Also using count to determine number of processes does not make
sense unless thousands of cores.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tests/gem_evict_everything.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/tests/gem_evict_everything.c b/tests/gem_evict_everything.c
index 41abef7..90c3ae1 100644
--- a/tests/gem_evict_everything.c
+++ b/tests/gem_evict_everything.c
@@ -135,8 +135,6 @@ static void exchange_uint32_t(void *array, unsigned i, unsigned j)
i_arr[j] = i_tmp;
}
-#define min(a, b) ((a) < (b) ? (a) : (b))
-
#define INTERRUPTIBLE (1 << 0)
#define SWAPPING (1 << 1)
#define DUP_DRMFD (1 << 2)
@@ -168,7 +166,7 @@ static void forked_evictions(int fd, int size, int count,
for (n = 0; n < bo_count; n++)
bo[n] = gem_create(fd, size);
- igt_fork(i, min(count, min(num_threads * 5, 12))) {
+ igt_fork(i, num_threads * 4) {
int realfd = fd;
int num_passes = flags & SWAPPING ? 10 : 100;
@@ -184,7 +182,7 @@ static void forked_evictions(int fd, int size, int count,
realfd = drm_open_any();
/* We can overwrite the bo array since we're forked. */
- for (l = 0; l < count; l++) {
+ for (l = 0; l < bo_count; l++) {
uint32_t flink;
flink = gem_flink(fd, bo[l]);
@@ -194,9 +192,9 @@ static void forked_evictions(int fd, int size, int count,
}
for (pass = 0; pass < num_passes; pass++) {
- copy(realfd, bo[0], bo[1], bo, count, 0);
+ copy(realfd, bo[0], bo[1], bo, bo_count, 0);
- for (l = 0; l < count && (flags & MEMORY_PRESSURE); l++) {
+ for (l = 0; l < bo_count && (flags & MEMORY_PRESSURE); l++) {
uint32_t *base = gem_mmap__cpu(realfd, bo[l],
size,
PROT_READ | PROT_WRITE);
@@ -244,7 +242,7 @@ static void swapping_evictions(int fd, int size, int count)
igt_permute_array(bo, bo_count, exchange_uint32_t);
for (pass = 0; pass < 100; pass++) {
- copy(fd, bo[0], bo[1], bo, count, 0);
+ copy(fd, bo[0], bo[1], bo, bo_count, 0);
}
}
--
1.8.4.3
next reply other threads:[~2013-12-06 11:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 11:37 Tvrtko Ursulin [this message]
2013-12-06 12:12 ` [PATCH] tests/gem_evict_everything: Use bo_count instead of count where intended Daniel Vetter
2013-12-06 12:33 ` Tvrtko Ursulin
2013-12-06 13:46 ` Daniel Vetter
2013-12-06 14:04 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386329869-12379-1-git-send-email-tvrtko.ursulin@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox