Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 04/10] drm/i915: split aligned height calculation out
Date: Tue, 17 Dec 2013 14:46:55 -0800	[thread overview]
Message-ID: <1387320421-857-4-git-send-email-jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <1387320421-857-1-git-send-email-jbarnes@virtuousgeek.org>

For use by get_plane_config.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 0b8a058a..367d64d 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -1921,6 +1921,14 @@ static bool need_vtd_wa(struct drm_device *dev)
 	return false;
 }
 
+static int intel_align_height(struct drm_device *dev, int height, bool tiled)
+{
+	int tile_height;
+
+	tile_height = IS_GEN2(dev) ? 16 : 8;
+	return ALIGN(height, tiled ? tile_height : 1);
+}
+
 int
 intel_pin_and_fence_fb_obj(struct drm_device *dev,
 			   struct drm_i915_gem_object *obj,
@@ -10392,7 +10400,7 @@ int intel_framebuffer_init(struct drm_device *dev,
 			   struct drm_mode_fb_cmd2 *mode_cmd,
 			   struct drm_i915_gem_object *obj)
 {
-	int aligned_height, tile_height;
+	int aligned_height;
 	int pitch_limit;
 	int ret;
 
@@ -10486,9 +10494,8 @@ int intel_framebuffer_init(struct drm_device *dev,
 	if (mode_cmd->offsets[0] != 0)
 		return -EINVAL;
 
-	tile_height = IS_GEN2(dev) ? 16 : 8;
-	aligned_height = ALIGN(mode_cmd->height,
-			       obj->tiling_mode ? tile_height : 1);
+	aligned_height = intel_align_height(dev, mode_cmd->height,
+					    obj->tiling_mode);
 	/* FIXME drm helper for size checks (especially planar formats)? */
 	if (obj->base.size < aligned_height * mode_cmd->pitches[0])
 		return -EINVAL;
-- 
1.8.4.2

  parent reply	other threads:[~2013-12-17 22:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17 22:46 [PATCH 01/10] drm/i915/vlv: add early DPIO init v3 Jesse Barnes
2013-12-17 22:46 ` [PATCH 02/10] drm/i915/vlv: split DPIO init and reset Jesse Barnes
2013-12-17 22:46 ` [PATCH 03/10] drm/i915: read out hw state earlier Jesse Barnes
2013-12-17 22:46 ` Jesse Barnes [this message]
2013-12-17 22:46 ` [PATCH 05/10] drm/i915: retrieve current fb config into new plane_config structure at init v8 Jesse Barnes
2013-12-18 10:36   ` Jani Nikula
2013-12-18 16:14     ` Jesse Barnes
2013-12-17 22:46 ` [PATCH 06/10] drm/i915: alloc intel_fb in the intel_fbdev struct Jesse Barnes
2013-12-17 22:46 ` [PATCH 07/10] drm/i915: allow re-use BIOS connector config for initial fbdev config Jesse Barnes
2013-12-17 22:46 ` [PATCH 08/10] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v8 Jesse Barnes
2013-12-17 22:47 ` [PATCH 09/10] port hotplug status live fix for VLV Jesse Barnes
2013-12-17 22:47 ` [PATCH 10/10] convert to using crtc->fb for BIOS fb management Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387320421-857-4-git-send-email-jbarnes@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox