From: Damien Lespiau <damien.lespiau@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: [PATCH 4/5] drm: Add support for subclassing struct drm_device
Date: Wed, 8 Jan 2014 18:31:51 +0000 [thread overview]
Message-ID: <1389205912-16632-5-git-send-email-damien.lespiau@intel.com> (raw)
In-Reply-To: <1389205912-16632-1-git-send-email-damien.lespiau@intel.com>
Currently, drivers are expected to allocate private data and attach it
to dev_private in struct drm_device.
This has the unfortunate property to require driver code to juggle
between the pointer to struct drm_device and dev->dev_private instead of
using the same pointer if they could embed the device structure.
This patch enables drivers to declare the size of the device structure
they want DRM core to create for them.
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
drivers/gpu/drm/drm_stub.c | 8 +++++++-
include/drm/drmP.h | 8 ++++++++
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
index 98a33c580..161dd9a 100644
--- a/drivers/gpu/drm/drm_stub.c
+++ b/drivers/gpu/drm/drm_stub.c
@@ -433,8 +433,14 @@ struct drm_device *drm_dev_alloc(struct drm_driver *driver,
{
struct drm_device *dev;
int ret;
+ size_t device_struct_size;
- dev = kzalloc(sizeof(*dev), GFP_KERNEL);
+ if (driver->device_struct_size)
+ device_struct_size = driver->device_struct_size;
+ else
+ device_struct_size = sizeof(*dev);
+
+ dev = kzalloc(device_struct_size, GFP_KERNEL);
if (!dev)
return NULL;
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 6800c20..219b153 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -996,6 +996,14 @@ struct drm_driver {
u32 driver_features;
/* size of the private data attached to a struct drm_buf */
int buf_priv_size;
+ /*
+ * DRM drivers can subclass struct drm_device to have their own device
+ * structure to store private data. In this case, they need to declare
+ * the size of the child structure (ie the structure embedding a struct
+ * drm_device as first field) for the DRM core to allocate a big
+ * enough device structure.
+ */
+ size_t device_struct_size;
const struct drm_ioctl_desc *ioctls;
int num_ioctls;
const struct file_operations *fops;
--
1.8.3.1
next prev parent reply other threads:[~2014-01-08 18:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 18:31 [RFC] Subclassing struct drm_device Damien Lespiau
2014-01-08 18:31 ` [PATCH 1/5] drm: Remove unnecessary dev_priv_size initializations to 0 Damien Lespiau
2014-01-08 18:31 ` [PATCH 2/5] drm: Remove dev_priv_size from struct drm_buf Damien Lespiau
2014-01-08 18:31 ` [PATCH 3/5] drm: Rename dev_priv_size to buf_priv_size Damien Lespiau
2014-01-08 18:31 ` Damien Lespiau [this message]
2014-01-08 19:01 ` [PATCH 4/5] drm: Add support for subclassing struct drm_device David Herrmann
2014-01-08 20:26 ` Daniel Vetter
2014-01-09 12:11 ` Damien Lespiau
2014-01-09 12:18 ` David Herrmann
2014-01-08 18:31 ` [PATCH 5/5] drm/i915: Make struct drm_i915_private a subclass of " Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389205912-16632-5-git-send-email-damien.lespiau@intel.com \
--to=damien.lespiau@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox