From: Sagar Arun Kamble <sagar.a.kamble@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: Add rotation support for the cursor plane
Date: Mon, 17 Feb 2014 22:53:50 +0530 [thread overview]
Message-ID: <1392657830.28501.52.camel@sagar-desktop> (raw)
In-Reply-To: <20140214113929.GG3852@intel.com>
On Fri, 2014-02-14 at 13:39 +0200, Ville Syrjälä wrote:
> On Fri, Feb 14, 2014 at 04:31:17PM +0530, Sagar Arun Kamble wrote:
> > On Wed, 2014-02-12 at 23:15 +0200, ville.syrjala@linux.intel.com wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > The cursor plane also supports 180 degree rotation. Add a new
> > > "cursor-rotation" property on the crtc which controls this.
> > >
> > > Unlike sprites, the cursor has a fixed size, so if you have a small
> > > cursor image with the rest of the bo filled by transparent pixels,
> > > simply flipping the rotation property will cause the visible part
> > > of the cursor to shift. This is something to keep in mind when
> > > using cursor rotation.
> > By flipping you meant setting 180 degree rotation?
>
> Yes.
>
> > Don't we have to adjust the cursor base as well to the lower right
> > corner apart from setting the control bit?
>
> No, the hardware does that automagically. Hmm. Except on gen4
> apparently. Looks like I need to test on gen4, and fix it if it's
> really the case.
I tried on BYT system and 180 rotation on cursor plane is showing
garbage data in cursor plane. We might need to adjust the cursor base.
Another thing, pipe rotation somehow did not work for me when I do this:
echo 0x4 > /sys/kernel/debug/dri/0/i915_pipe_rotation
Only cursor plane had impact. Need to debug this as well.
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-02-17 17:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 21:14 [PATCH 0/5] drm/i915: Full pipe rotation & rotation property name bikeshedding ville.syrjala
2014-02-12 21:15 ` [PATCH 1/5] drm: Pass name to drm_rotation_property_create() ville.syrjala
2014-02-13 10:42 ` Sagar Arun Kamble
2014-02-12 21:15 ` [PATCH 2/5] drm/i915: Rename primary plane rotation property to "plane-rotation" ville.syrjala
2014-02-13 12:37 ` Sagar Arun Kamble
2014-02-13 13:46 ` Ville Syrjälä
2014-02-13 14:06 ` Ville Syrjälä
2014-02-13 14:20 ` [Intel-gfx] " Chris Wilson
2014-02-13 14:40 ` Ville Syrjälä
2014-02-12 21:15 ` [PATCH 3/5] drm: Add drm_rotation_chain() ville.syrjala
2014-02-12 21:15 ` [PATCH 4/5] drm/i915: Add rotation support for the cursor plane ville.syrjala
2014-02-14 11:01 ` Sagar Arun Kamble
2014-02-14 11:39 ` Ville Syrjälä
2014-02-17 17:23 ` Sagar Arun Kamble [this message]
2014-02-17 17:51 ` Ville Syrjälä
2014-02-18 7:49 ` Sagar Arun Kamble
2014-02-18 9:23 ` Ville Syrjälä
2014-02-18 10:09 ` Sagar Arun Kamble
2014-02-12 21:15 ` [PATCH 5/5] drm/i915: Add full pipe rotation ville.syrjala
2014-02-19 10:25 ` Sagar Arun Kamble
2014-02-12 23:17 ` [PATCH 0/5] drm/i915: Full pipe rotation & rotation property name bikeshedding Chris Wilson
2014-02-13 8:51 ` Ville Syrjälä
2014-02-13 11:20 ` Chris Wilson
2014-02-13 11:58 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392657830.28501.52.camel@sagar-desktop \
--to=sagar.a.kamble@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox