Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/6] drm/i915: make CRTC enable/disable asynchronous
Date: Thu, 06 Mar 2014 01:43:51 +0200	[thread overview]
Message-ID: <1394063031.4236.15.camel@ideak-mobl> (raw)
In-Reply-To: <20140305153940.2bb00a2c@jbarnes-desktop>

On Wed, 2014-03-05 at 15:39 -0800, Jesse Barnes wrote:
> On Thu, 06 Mar 2014 01:29:14 +0200
> Imre Deak <imre.deak@intel.com> wrote:
> 
> > On Wed, 2014-03-05 at 14:48 -0800, Jesse Barnes wrote:
> > > This lets us return to userspace more quickly and should improve init
> > > and suspend/resume times as well, allowing us to return to userspace
> > > sooner.
> > 
> > IMHO this is a good move towards a full command queue based solution for
> > kms commands, where eventually we have to think less of concurrency.
> > That is if we can queue all the other kms commands too (flip,
> > set_plane). But I don't see why that wouldn't be possible.
> > 
> > Btw, why do you have a separate disable and enable queue?
> 
> As opposed to a dedicated work queue for both combined?  I had a
> separate queue in an earlier patch, but dropped it while debugging some
> other stuff.  We should bring it back to ensure ordering.  That would
> remove the need for a few of the syncs, and would also let us queue a
> check at the appropriate time on the same queue.

Ah, sorry I confused myself. I didn't notice you used the global
workqueue. I'm not sure about the ordering guarantees of the global
workqueue, but if that's not given then yea a dedicated ordered
workqueue would seem better.

In any case if this can move towards a more generic command queue
solution then it's great.

--Imre

  reply	other threads:[~2014-03-05 23:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 22:48 Make init and mode set more asynchronous Jesse Barnes
2014-03-05 22:48 ` [PATCH 1/6] drm/i915: make CRTC enable/disable asynchronous Jesse Barnes
2014-03-05 23:29   ` Imre Deak
2014-03-05 23:39     ` Jesse Barnes
2014-03-05 23:43       ` Imre Deak [this message]
2014-03-06  9:35   ` Chris Wilson
2014-03-06 16:14     ` Jesse Barnes
2014-03-05 22:48 ` [PATCH 2/6] drm/i915: make fbdev initialization asynchronous Jesse Barnes
2014-03-06  9:12   ` Chris Wilson
2014-03-06 16:17     ` Jesse Barnes
2014-03-06 20:15       ` Chris Wilson
2014-03-05 22:48 ` [PATCH 3/6] drm/i915/dp: put power sequence info into intel_dp Jesse Barnes
2014-03-05 22:48 ` [PATCH 4/6] drm: take modeset locks around initial fb helper probing Jesse Barnes
2014-03-06  9:14   ` Chris Wilson
2014-03-05 22:48 ` [PATCH 5/6] drm/i915/dp: push eDP caching out into a work queue Jesse Barnes
2014-03-06  9:28   ` Ville Syrjälä
2014-03-06 16:19     ` Jesse Barnes
2014-03-05 22:48 ` [PATCH 6/6] drm/i915/dp: make sure VDD is on around link status checking Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394063031.4236.15.camel@ideak-mobl \
    --to=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox