From: Ben Widawsky <benjamin.widawsky@intel.com>
To: Intel GFX <intel-gfx@lists.freedesktop.org>
Cc: Ben Widawsky <ben@bwidawsk.net>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: [PATCH 3/5] drm/i915: WARN on unexpected return from drm_mm
Date: Sat, 3 May 2014 10:56:00 -0700 [thread overview]
Message-ID: <1399139762-20728-4-git-send-email-benjamin.widawsky@intel.com> (raw)
In-Reply-To: <1399139762-20728-1-git-send-email-benjamin.widawsky@intel.com>
We only actually want to retry if the failure mode was not enough space,
and so we'll evict. This will help us realize quickly in case we missed
a change in the common drm code.
NOTE: A similar check is already in place for the GEN7 PPGTT code.
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
---
drivers/gpu/drm/i915/i915_gem.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index d03702ac..1f85ec5 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -3233,6 +3233,9 @@ i915_gem_find_vm_space(struct i915_address_space *vm,
DRM_MM_SEARCH_DEFAULT,
DRM_MM_CREATE_DEFAULT);
if (ret) {
+ if (WARN_ON(ret != -ENOSPC))
+ return ret;
+
ret = i915_gem_evict_something(vm->dev, vm, size, align, color,
flags);
if (ret == 0)
--
1.9.2
next prev parent reply other threads:[~2014-05-03 17:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 17:55 [PATCH 0/5] untested DRM node alloc cleanups Ben Widawsky
2014-05-03 17:55 ` [PATCH 1/5] drm/i915: Use topdown allocation for PPGTT PDEs on gen6/7 Ben Widawsky
2014-05-03 17:55 ` [PATCH 2/5] drm/i915: Extract node allocation from bind Ben Widawsky
2014-05-03 17:56 ` Ben Widawsky [this message]
2014-05-03 17:56 ` [PATCH 4/5] drm/i915: Limit the number of node allocation retries Ben Widawsky
2014-05-03 17:56 ` [PATCH 5/5] drm/i915: Use new drm node allocator for PPGTT Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399139762-20728-4-git-send-email-benjamin.widawsky@intel.com \
--to=benjamin.widawsky@intel.com \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox