Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/3] igt/gem_cpu_reloc: Check HW exists before attempting to use it
Date: Thu, 17 May 2018 08:08:14 -0700	[thread overview]
Message-ID: <13ce486d-b2cf-7fa4-2630-fd6197e24b36@intel.com> (raw)
In-Reply-To: <20180517082330.32760-1-chris@chris-wilson.co.uk>



On 17/05/18 01:23, Chris Wilson wrote:
> Confirm we have the available HW before asserting it succeeds.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/gem_cpu_reloc.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/gem_cpu_reloc.c b/tests/gem_cpu_reloc.c
> index 882c312d4..e3bbcd239 100644
> --- a/tests/gem_cpu_reloc.c
> +++ b/tests/gem_cpu_reloc.c
> @@ -167,6 +167,7 @@ static void run_test(int fd, int count)
>   	use_blt = 0;

Is this^ meant to be EXEC_DEFAULT?

>   	if (intel_gen(noop) >= 6)
>   		use_blt = I915_EXEC_BLT;
> +	gem_require_ring(fd, use_blt);

Are any gens 6+ that do not have a BLT ring? if that is the case 
shouldn't we use '0' like we do for 5- gens?

Thanks,
Antonio

>   
>   	if (intel_gen(noop) >= 8) {
>   		batch = gen8_batch;
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-05-17 15:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17  8:23 [PATCH i-g-t 1/3] igt/gem_cpu_reloc: Check HW exists before attempting to use it Chris Wilson
2018-05-17  8:23 ` [PATCH i-g-t 2/3] igt/gem_blits: Check for blitter support before use Chris Wilson
2018-05-17 17:58   ` Antonio Argenziano
2018-05-17  8:23 ` [PATCH i-g-t 3/3] igt/kms_frontbuffer_tracking: Skip over IGT_DRAW_BLT when there's no BLT Chris Wilson
2018-05-17  9:56   ` [PATCH i-g-t] " Chris Wilson
2018-05-17 23:16     ` Antonio Argenziano
2018-05-17  9:28 ` ✗ Fi.CI.BAT: failure for series starting with [1/3] igt/gem_cpu_reloc: Check HW exists before attempting to use it Patchwork
2018-05-17 10:38 ` ✓ Fi.CI.BAT: success for series starting with [1/3] igt/gem_cpu_reloc: Check HW exists before attempting to use it (rev2) Patchwork
2018-05-17 13:43 ` ✓ Fi.CI.IGT: " Patchwork
2018-05-17 15:08 ` Antonio Argenziano [this message]
2018-05-17 15:37   ` [PATCH i-g-t 1/3] igt/gem_cpu_reloc: Check HW exists before attempting to use it Chris Wilson
2018-05-17 16:29     ` Antonio Argenziano
2018-05-17 16:52       ` Chris Wilson
2018-05-17 17:01         ` Antonio Argenziano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13ce486d-b2cf-7fa4-2630-fd6197e24b36@intel.com \
    --to=antonio.argenziano@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox