From: Konrad Zapalowicz <bergo.torino@gmail.com>
To: daniel.vetter@ffwll.ch
Cc: jani.nikula@linux.intel.com, airlied@linux.ie,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Konrad Zapalowicz <bergo.torino@gmail.com>
Subject: [PATCH] drivers/i915: Fix unnoticed failure of init_ring_common()
Date: Thu, 19 Jun 2014 00:38:54 +0200 [thread overview]
Message-ID: <1403131134-9533-1-git-send-email-bergo.torino@gmail.com> (raw)
This commit add check for return value of init_ring_common() in the
init_render_ring(). Now, when failure is detected the error code is
propagated to the caller layer instead of being ignored.
I believe that this fix will have a positive impact on the oops that
I hit recently and which starts when init_ring_common() fails:
[drm:init_ring_common] *ERROR* render ring initialization failed
ctl 0001f001 head 0000000c tail 00000000 start 003eb000
BUG: unable to handle kernel NULL pointer dereference at 0000006c
IP: [<f8ca1679>] i915_gem_obj_to_ggtt+0x9/0x40 [i915]
Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 279488a..d205b0d 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -604,6 +604,8 @@ static int init_render_ring(struct intel_engine_cs *ring)
struct drm_device *dev = ring->dev;
struct drm_i915_private *dev_priv = dev->dev_private;
int ret = init_ring_common(ring);
+ if (ret)
+ return ret;
/* WaTimedSingleVertexDispatch:cl,bw,ctg,elk,ilk,snb */
if (INTEL_INFO(dev)->gen >= 4 && INTEL_INFO(dev)->gen < 7)
--
1.8.1.2
next reply other threads:[~2014-06-18 22:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 22:38 Konrad Zapalowicz [this message]
2014-06-19 6:15 ` [PATCH] drivers/i915: Fix unnoticed failure of init_ring_common() Daniel Vetter
2014-06-19 12:45 ` Konrad Zapalowicz
2014-06-19 14:35 ` Daniel Vetter
2014-06-19 14:36 ` Daniel Vetter
2014-06-19 14:42 ` Konrad Zapalowicz
2014-06-19 17:07 ` [PATCH v2] " Konrad Zapalowicz
2014-06-19 19:00 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403131134-9533-1-git-send-email-bergo.torino@gmail.com \
--to=bergo.torino@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox