public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Thomas Wood <thomas.wood@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: daniel.vetter@ffwll.ch
Subject: [PATCH i-g-t 1/8] lib: warn when attempting to run an unknown subtest
Date: Wed, 23 Jul 2014 11:57:48 +0100	[thread overview]
Message-ID: <1406113075-30860-2-git-send-email-thomas.wood@intel.com> (raw)
In-Reply-To: <1406113075-30860-1-git-send-email-thomas.wood@intel.com>

Signed-off-by: Thomas Wood <thomas.wood@intel.com>
---
 lib/igt_core.c | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/lib/igt_core.c b/lib/igt_core.c
index b197932..5c20581 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -204,6 +204,7 @@ static unsigned int exit_handler_count;
 /* subtests helpers */
 static bool list_subtests = false;
 static char *run_single_subtest = NULL;
+static bool run_single_subtest_found = false;
 static const char *in_subtest = NULL;
 static bool in_fixture = false;
 static bool test_with_subtests = false;
@@ -484,9 +485,14 @@ bool __igt_run_subtest(const char *subtest_name)
 		return false;
 	}
 
-	if (run_single_subtest &&
-	    strcmp(subtest_name, run_single_subtest) != 0)
-		return false;
+	if (run_single_subtest) {
+		if (strcmp(subtest_name, run_single_subtest) != 0)
+			return false;
+		else
+			run_single_subtest_found = true;
+	}
+
+
 
 	if (skip_subtests_henceforth) {
 		printf("Subtest %s: %s\n", subtest_name,
@@ -722,6 +728,12 @@ void igt_exit(void)
 {
 	igt_exit_called = true;
 
+	if (run_single_subtest && !run_single_subtest_found) {
+		igt_warn("Unknown subtest: %s\n", run_single_subtest);
+		exit(-1);
+	}
+
+
 	if (igt_only_list_subtests())
 		exit(IGT_EXIT_SUCCESS);
 
-- 
1.9.3

  reply	other threads:[~2014-07-23 10:58 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 10:57 [PATCH i-g-t 0/8] command line parsing Thomas Wood
2014-07-23 10:57 ` Thomas Wood [this message]
2014-07-24  9:49   ` [PATCH i-g-t 1/8] lib: warn when attempting to run an unknown subtest Gore, Tim
2014-07-23 10:57 ` [PATCH i-g-t 2/8] tests: remove unused getopt header includes Thomas Wood
2014-07-24  9:50   ` Gore, Tim
2014-07-23 10:57 ` [PATCH i-g-t 3/8] lib: move option parsing into common_init Thomas Wood
2014-07-23 12:13   ` Daniel Vetter
2014-07-23 12:15     ` Daniel Vetter
2014-07-24  9:52   ` Gore, Tim
2014-07-23 10:57 ` [PATCH i-g-t 4/8] lib: add igt_simple_init_parse_opts Thomas Wood
2014-07-24  9:54   ` Gore, Tim
2014-07-23 10:57 ` [PATCH i-g-t 5/8] lib: don't ignore unknown options in multi-tests Thomas Wood
2014-07-24  9:55   ` Gore, Tim
2014-07-23 10:57 ` [PATCH i-g-t 6/8] tests: convert simple tests to use igt_simple_init_parse_opts Thomas Wood
2014-07-24 10:17   ` Gore, Tim
2014-07-25 16:08     ` [PATCH i-g-t] lib: avoid getopt value conflicts with tests Thomas Wood
2014-07-25 16:57       ` Paulo Zanoni
2014-07-28  9:38         ` Thomas Wood
2014-07-28 15:18           ` [PATCH i-g-t] lib: check test options for conflicts Thomas Wood
2014-07-23 10:57 ` [PATCH i-g-t 7/8] lib: always warn about unknown options Thomas Wood
2014-07-24 10:33   ` Gore, Tim
2014-07-23 10:57 ` [PATCH i-g-t 8/8] lib: add a command line option to enable debug output in tests Thomas Wood
2014-07-24 10:37   ` Gore, Tim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406113075-30860-2-git-send-email-thomas.wood@intel.com \
    --to=thomas.wood@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox