Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: arun.siluvery@linux.intel.com
To: intel-gfx@lists.freedesktop.org
Subject: [RFC 0/2] Add test to verify BDW workarounds
Date: Fri,  8 Aug 2014 10:54:54 +0100	[thread overview]
Message-ID: <1407491696-31727-1-git-send-email-arun.siluvery@linux.intel.com> (raw)

From: Arun Siluvery <arun.siluvery@linux.intel.com>

Currently in BDW workarounds are initialized in init_clock_gating() but
some of them are lost followed by a gpu reset. The solution is to apply
them in golden render state which keeps them valid when starting with an
uninitialized state.

First patch adds workaround registers to golden render state. This patch
uses functions which are part two other patches, one of which is not yet
sent for upstream [2].

[1] https://www.mail-archive.com/intel-gfx@lists.freedesktop.org/msg43044.html
[2] From cc8f2f657c44d7c017e70e1af11b4513358b6a0a Mon Sep 17 00:00:00 2001
From: Deepak S <deepak.s@linux.intel.com>
Date: Sat, 2 Aug 2014 20:05:07 +0530
Subject: [PATCH 2/3] tools/null_state_render: Add ROW CHICKEN BIT Registers to
 golden render state

As per, latest Bspec, some of the RenderCS registers are expected to be
added in context. We achive this by adding the registers Golden render
state.

Signed-off-by: Deepak S <deepak.s@linux.intel.com>


Second patch adds a simple test which captures workaround register data
before and after a gpu reset and compares them. Suspend/Resume is currently
not working hence it is not tested.

The test uses intel_reg_read() to read register data but I observed that
this value is different from the one compared to using I915_READ() from
within the driver.
e.g., in case of CACHE_MODE_1 with WA applied it should be 0x01C0.
intel_reg_read() gives 0x0180 whereas with I915_READ() it is 0x01C0.

Arun Siluvery (2):
  tools/null_state_render: Add BDW workarounds to golden render state
  igt/gem_workarounds: igt to test workaround registers

 lib/intel_reg.h                               |  30 ++++
 tests/Makefile.sources                        |   1 +
 tests/gem_workarounds.c                       | 211 ++++++++++++++++++++++++++
 tools/null_state_gen/intel_renderstate_gen8.c |  37 +++++
 4 files changed, 279 insertions(+)
 create mode 100644 tests/gem_workarounds.c

-- 
2.0.4

             reply	other threads:[~2014-08-08  9:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-08  9:54 arun.siluvery [this message]
2014-08-08  9:54 ` [RFC 1/2] tools/null_state_render: Add BDW workarounds to golden render state arun.siluvery
2014-08-08  9:54 ` [RFC 2/2] igt/gem_workarounds: igt to test workaround registers arun.siluvery
2014-08-08 14:12   ` Daniel Vetter
2014-08-08 16:39     ` Siluvery, Arun
2014-08-08 17:00       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407491696-31727-1-git-send-email-arun.siluvery@linux.intel.com \
    --to=arun.siluvery@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox