From: Imre Deak <imre.deak@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: sanitize RPS resetting during GPU reset
Date: Thu, 27 Nov 2014 21:26:23 +0200 [thread overview]
Message-ID: <1417116383.6632.12.camel@ideak-mobl> (raw)
In-Reply-To: <20141127190735.GA32117@phenom.ffwll.local>
On Thu, 2014-11-27 at 20:07 +0100, Daniel Vetter wrote:
> On Thu, Nov 27, 2014 at 01:08:58PM +0200, Imre Deak wrote:
> > On Thu, 2014-11-20 at 23:01 +0200, Imre Deak wrote:
> > > Atm, we don't disable RPS interrupts and related work items before
> > > resetting the GPU. This may interfere with the following GPU
> > > initialization and cause RPS interrupts to show up in PM_IIR too early
> > > before calling gen6_enable_rps_interrupts() (triggering a WARN there).
> > >
> > > Solve this by disabling RPS interrupts and flushing any related work
> > > items before resetting the GPU.
> > >
> > > Reported-by: He, Shuang <shuang.he@intel.com>
> > > Testcase: igt/gem_reset_stats/ban-render
> > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86644
>
> Also this fixes a regression introduced in
>
> commit 3cc134e3ee09055d5a87193fc7eb0ecf4a59eaa1
> Author: Imre Deak <imre.deak@intel.com>
> Date: Wed Nov 19 15:30:03 2014 +0200
>
> drm/i915: sanitize rps irq enabling
This issue has been always around it was just less likely to trigger the
WARN. The above commit only made this happen all the time.
>
> Paulo, can you please review Imre's patches?
> -Daniel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-27 19:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 21:01 [PATCH 1/2] drm/i915: mask RPS IRQs properly when disabling RPS Imre Deak
2014-11-20 21:01 ` [PATCH 2/2] drm/i915: sanitize RPS resetting during GPU reset Imre Deak
2014-11-22 23:17 ` [PATCH 2/2] drm/i915: sanitize RPS resetting during GPU shuang.he
2014-11-27 11:08 ` [PATCH 2/2] drm/i915: sanitize RPS resetting during GPU reset Imre Deak
2014-11-27 19:07 ` Daniel Vetter
2014-11-27 19:26 ` Imre Deak [this message]
2014-12-01 17:35 ` Paulo Zanoni
2014-12-01 16:29 ` [PATCH 1/2] drm/i915: mask RPS IRQs properly when disabling RPS Paulo Zanoni
2014-12-01 16:34 ` Chris Wilson
2014-12-01 16:47 ` Paulo Zanoni
2014-12-01 17:13 ` Imre Deak
2014-12-01 17:26 ` Daniel Vetter
2014-12-01 16:42 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417116383.6632.12.camel@ideak-mobl \
--to=imre.deak@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox