public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Marc Herbert <marc.herbert@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Marc Herbert <marc.herbert@intel.com>
Subject: [PATCH i-g-t] remove tests dependency on VT /dev/tty0
Date: Thu, 19 Feb 2015 16:38:42 -0800	[thread overview]
Message-ID: <1424392723-21741-1-git-send-email-marc.herbert@intel.com> (raw)

Hi,

  In a private communication Thomas Wood recommended the use of
igt_warn() over my initial igt_debug(), since the lack of /dev/tty0
"could indicate a problem". Unfortunately I have no idea what kind of
problem this could indicate outside ChromeOS. On the other hand, I'm
fairly sure that systematically printing a warning on every single
ChromeOS release going forward will create a "cry wolf" problem,
reducing users' attention to warnings and discouraging QA from collecting
them.

The top priority is obviously the ability to run the tests at all -
thus the current patch. But if someone can think of a silver and
relatively cheap bullet that would suit all usecases then please let
me/us know ASAP.

Cheers,

Marc

Marc Herbert (1):
  lib/igt_kms.c: remove tests dependency on VT /dev/tty0

 lib/igt_kms.c | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

-- 
1.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2015-02-20  0:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20  0:38 Marc Herbert [this message]
2015-02-20  0:38 ` [PATCH i-g-t] lib/igt_kms.c: remove tests dependency on VT /dev/tty0 Marc Herbert
2015-02-24  0:03   ` Daniel Vetter
2015-02-24 16:12     ` Thomas Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424392723-21741-1-git-send-email-marc.herbert@intel.com \
    --to=marc.herbert@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox