From: Ander Conselvan De Oliveira <conselvan2@gmail.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/3] drm/i915: Don't check modeset state in the hw state force restore path
Date: Wed, 17 Jun 2015 15:29:43 +0300 [thread overview]
Message-ID: <1434544183.2898.4.camel@gmail.com> (raw)
In-Reply-To: <87r3pa354b.fsf@intel.com>
On Wed, 2015-06-17 at 15:13 +0300, Jani Nikula wrote:
> On Wed, 17 Jun 2015, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> > On Tue, 16 Jun 2015, Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> wrote:
> >> Since the force restore logic will restore the CRTCs state one at a
> >> time, it is possible that the state will be inconsistent until the whole
> >> operation finishes. A call to intel_modeset_check_state() is done once
> >> it's over, so don't check the state multiple times in between. This
> >> regression was introduced in:
> >>
> >> commit 7f27126ea3db6ade886f18fd39caf0ff0cd1d37f
> >> Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> >> Date: Wed Nov 5 14:26:06 2014 -0800
> >>
> >> drm/i915: factor out compute_config from __intel_set_mode v3
> >>
> >> v2: Rename check parameter to force_restore. (Matt)
> >>
> >> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=94431
> >> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> >> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> >> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> >
> > All three patches applied to drm-intel-next-fixes, aiming for v4.2 merge
> > window. Thanks for the patches and review.
> >
> > For drm-intel-nightly, I resolved the conflicts by ignoring these
> > changes and favoring what's in drm-intel-next-queued. Fingers crossed I
> > didn't botch it up!
>
> Also, do we need some of these in v4.1 or earlier as well? Should we
> backport once these are upstream?
The regression 1/3 solves goes back to v3.19. The other patches are only
relevant for 4.2 and later.
Thanks,
Ander
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-17 12:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 8:49 [PATCH v2 1/3] drm/i915: Don't check modeset state in the hw state force restore path Ander Conselvan de Oliveira
2015-06-16 8:49 ` [PATCH v2 2/3] drm/i915: Don't update staged config during force restore modesets Ander Conselvan de Oliveira
2015-06-16 8:49 ` [PATCH v2 3/3] drm/i915: Don't set enabled value of all CRTCs when restoring the mode Ander Conselvan de Oliveira
2015-06-17 12:04 ` [PATCH v2 1/3] drm/i915: Don't check modeset state in the hw state force restore path Jani Nikula
2015-06-17 12:13 ` Jani Nikula
2015-06-17 12:29 ` Ander Conselvan De Oliveira [this message]
2015-06-17 12:35 ` Ander Conselvan De Oliveira
2015-06-17 12:42 ` Jani Nikula
2015-06-17 13:23 ` Ander Conselvan De Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434544183.2898.4.camel@gmail.com \
--to=conselvan2@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox