Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: factor out intel_mode_target_cdclk
Date: Mon, 22 Jun 2015 16:46:37 +0300	[thread overview]
Message-ID: <1434980797.31905.91.camel@intel.com> (raw)
In-Reply-To: <20150622133733.GG13593@strange.amr.corp.intel.com>

On ma, 2015-06-22 at 14:37 +0100, Damien Lespiau wrote:
> On Wed, Jun 17, 2015 at 02:00:54PM +0300, Imre Deak wrote:
> > For GEN9 the target cdclk frequency is needed during the modeset state check
> > phase too, so factor out this functionality.
> > 
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> 
> I believe the "proper" way to do it is to put what you called the target
> CDCLK in the atomic state and use that here. Maarten has a patch to do
> that towards the end of his atomic series.

Yes, I was also thinking of using a pre-calculated value, but that
looked like a bigger work. I haven't seen Maarten's patch but that looks
like the way to go (Daniel also pointed to this on IRC). So I can rebase
this once Maarten's patchset lands.

--Imre

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2015-06-22 13:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17 11:00 [PATCH 1/2] drm/i915: factor out intel_mode_target_cdclk Imre Deak
2015-06-17 11:00 ` [PATCH 2/2] drm/i915/bxt: fix max scaling factor calculation Imre Deak
2015-06-22 13:37 ` [PATCH 1/2] drm/i915: factor out intel_mode_target_cdclk Damien Lespiau
2015-06-22 13:46   ` Imre Deak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434980797.31905.91.camel@intel.com \
    --to=imre.deak@intel.com \
    --cc=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox