From: Matt Roper <matthew.d.roper@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 0/2] Prevent (sleeping) wm updates under vblank evasion
Date: Mon, 22 Jun 2015 18:30:31 -0700 [thread overview]
Message-ID: <1435023033-18043-1-git-send-email-matthew.d.roper@intel.com> (raw)
Our low-level plane update functions, which get called while we're under vblank
evasion with IRQ's disabled, currently call intel_update_sprite_watermarks
which is a potentially sleeping operation. This fumble has been present in the
code ever since we added atomic vblank evasion. We actually do have a
mechanism to flag the need for wm updates and then perform them once evasion is
finished, but our handling of that flag is a bit busted at the moment (i.e.,
currently only being used when a plane gets disabled). Let's fix that...
Matt Roper (2):
drm/i915: Drop parameters to intel_update_sprite_watermarks()
drm/i915: Update sprite watermarks outside vblank evasion
drivers/gpu/drm/i915/intel_display.c | 26 +++++++++++++++++---------
drivers/gpu/drm/i915/intel_drv.h | 6 +-----
drivers/gpu/drm/i915/intel_pm.c | 21 +++++++++++++++------
drivers/gpu/drm/i915/intel_sprite.c | 21 ---------------------
4 files changed, 33 insertions(+), 41 deletions(-)
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2015-06-23 1:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 1:30 Matt Roper [this message]
2015-06-23 1:30 ` [PATCH 1/2] drm/i915: Drop parameters to intel_update_sprite_watermarks() Matt Roper
2015-06-23 1:30 ` [PATCH 2/2] drm/i915: Update sprite watermarks outside vblank evasion Matt Roper
2015-06-23 7:34 ` Daniel Vetter
2015-06-23 14:29 ` Matt Roper
2015-06-23 15:24 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435023033-18043-1-git-send-email-matthew.d.roper@intel.com \
--to=matthew.d.roper@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox