public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 0/7] FBC (+stolen) locking, v4
Date: Wed,  1 Jul 2015 17:15:19 -0300	[thread overview]
Message-ID: <1435781726-7282-1-git-send-email-przanoni@gmail.com> (raw)

From: Paulo Zanoni <paulo.r.zanoni@intel.com>

Hi

So, based on the reviews, here's v4 of the series, now with
dev_priv->mm.stolen_lock. This allows us to completely get rid of struct_mutex
locking around FBC calls. Kudos to Chris for the suggestion.

The patch that added intel_fbc_stop() got removed from this series because the
addition of mm.stolen_lock turned it into just an optimization instead of a
bugfix. Let's leave it to another series, where I'll also try to clarify all the
function names involved.

Since we didn't seem to reach any conclusions on the lockdep_assert_held vs
WARN_ON discussion, I kept using WARN_ON since it's what the maintainer is
asking and since it's what's winning in usage count. If we decide to change it,
we can always do it in a later patch.

Thanks,
Paulo

Paulo Zanoni (7):
  drm/i915: add simple wrappers for stolen node insertion/removal
  drm/i915: move FBC code out of i915_gem_stolen.c
  drm/i915: add dev_priv->mm.stolen_lock
  drm/i915: add the FBC mutex
  drm/i915: intel_frontbuffer_flip_prepare() doesn't need struct_mutex
  drm/i915: intel_unregister_dsm_handler() doesn't need struct_mutex
  drm/i915: FBC doesn't need struct_mutex anymore

 drivers/gpu/drm/i915/i915_debugfs.c    |   8 +-
 drivers/gpu/drm/i915/i915_dma.c        |   1 +
 drivers/gpu/drm/i915/i915_drv.h        |  14 +-
 drivers/gpu/drm/i915/i915_gem_stolen.c | 215 +++++++++--------------------
 drivers/gpu/drm/i915/intel_display.c   |  20 +--
 drivers/gpu/drm/i915/intel_drv.h       |   2 +
 drivers/gpu/drm/i915/intel_fbc.c       | 239 ++++++++++++++++++++++++++++++---
 7 files changed, 309 insertions(+), 190 deletions(-)

-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2015-07-01 20:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01 20:15 Paulo Zanoni [this message]
2015-07-01 20:15 ` [PATCH 1/7] drm/i915: add simple wrappers for stolen node insertion/removal Paulo Zanoni
2015-07-01 20:38   ` Chris Wilson
2015-07-02 13:33     ` Paulo Zanoni
2015-07-02 13:36       ` Chris Wilson
2015-07-02 19:07     ` Paulo Zanoni
2015-07-02 19:14       ` Chris Wilson
2015-07-06  8:41   ` Daniel Vetter
2015-07-01 20:15 ` [PATCH 2/7] drm/i915: move FBC code out of i915_gem_stolen.c Paulo Zanoni
2015-07-01 20:44   ` Chris Wilson
2015-07-02 13:39     ` Paulo Zanoni
2015-07-02 13:45       ` Chris Wilson
2015-07-06  8:44       ` Daniel Vetter
2015-07-01 20:15 ` [PATCH 3/7] drm/i915: add dev_priv->mm.stolen_lock Paulo Zanoni
2015-07-01 20:33   ` Chris Wilson
2015-07-01 20:15 ` [PATCH 4/7] drm/i915: add the FBC mutex Paulo Zanoni
2015-07-01 20:49   ` Chris Wilson
2015-07-02 22:27     ` Paulo Zanoni
2015-07-01 20:15 ` [PATCH 5/7] drm/i915: intel_frontbuffer_flip_prepare() doesn't need struct_mutex Paulo Zanoni
2015-07-01 20:15 ` [PATCH 6/7] drm/i915: intel_unregister_dsm_handler() " Paulo Zanoni
2015-07-01 20:15 ` [PATCH 7/7] drm/i915: FBC doesn't need struct_mutex anymore Paulo Zanoni
2015-07-01 20:50   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435781726-7282-1-git-send-email-przanoni@gmail.com \
    --to=przanoni@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox