From: tim.gore@intel.com
To: intel-gfx@lists.freedesktop.org
Cc: thomas.wood@intel.com
Subject: [PATCH i-g-t] lib/igt_gt.c : allow changes to stop_rings mode bits
Date: Fri, 10 Jul 2015 14:06:06 +0100 [thread overview]
Message-ID: <1436533566-11048-1-git-send-email-tim.gore@intel.com> (raw)
From: Tim Gore <tim.gore@intel.com>
In function igt_set_stop_rings, the test
igt_assert_f(flags == 0 || current == 0, ..
will fail if we are trying to force a hang but the
STOP_RINGS_ALLOW_BAN or STOP_RINGS_ALLOW_ERROR bit is set.
With the introduction of per ring resets in the driver
(in android) these bits do not get cleared to zero when
an individual ring is reset. This causes subsequent
attempt to cause a ring hang via this function to fail,
leading to several igt tests failing (ie gem_reset_stats
subtest ban-xxx etc).
So, modify this test to look only at the bits that are
used to hang the gpu rings.
Signed-off-by: Tim Gore <tim.gore@intel.com>
---
lib/igt_gt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/igt_gt.c b/lib/igt_gt.c
index 8e5e076..12c56fa 100644
--- a/lib/igt_gt.c
+++ b/lib/igt_gt.c
@@ -345,8 +345,8 @@ void igt_set_stop_rings(enum stop_ring_flags flags)
STOP_RING_ALLOW_ERRORS)) == 0);
current = igt_get_stop_rings();
- igt_assert_f(flags == 0 || current == 0,
- "previous i915_ring_stop is still 0x%x\n", current);
+ igt_assert_f( (flags & STOP_RING_ALL) == 0 || (current & STOP_RING_ALL) == 0,
+ "previous i915_ring_stop is still 0x%x\n", current);
stop_rings_write(flags);
current = igt_get_stop_rings();
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2015-07-10 13:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 13:06 tim.gore [this message]
2015-07-13 9:30 ` [PATCH i-g-t] lib/igt_gt.c : allow changes to stop_rings mode bits Daniel Vetter
2015-07-13 9:43 ` Gore, Tim
2015-07-13 14:59 ` Daniel Vetter
2015-07-13 16:07 ` Gore, Tim
2015-07-14 8:08 ` Daniel Vetter
2015-07-14 8:55 ` Gore, Tim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436533566-11048-1-git-send-email-tim.gore@intel.com \
--to=tim.gore@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.wood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox