Re: [PATCH] drm/i915: Fix build warning on 32-bit

From: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
To: "Vetter, Daniel" <daniel.vetter@intel.com>,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Fix build warning on 32-bit
Date: Mon, 17 Aug 2015 17:19:09 +0000	[thread overview]
Message-ID: <1439831947.2672.2.camel@intel.com> (raw)
In-Reply-To: <1439548523-15444-1-git-send-email-thierry.reding@gmail.com>

Em Sex, 2015-08-14 às 12:35 +0200, Thierry Reding escreveu:
> From: Thierry Reding <treding@nvidia.com>
> 
> The gtt.stolen_size field is of type size_t, and so should be printed
> using %zu to avoid build warnings on either 32-bit and 64-bit builds.

While the suggestion from Chris sounds good, this patch alone is
already a fix, so:
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_stolen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c 
> b/drivers/gpu/drm/i915/i915_gem_stolen.c
> index a36cb95ec798..f361c4a56995 100644
> --- a/drivers/gpu/drm/i915/i915_gem_stolen.c
> +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
> @@ -348,7 +348,7 @@ int i915_gem_init_stolen(struct drm_device *dev)
>  	 * memory, so just consider the start. */
>  	reserved_total = stolen_top - reserved_base;
>  
> -	DRM_DEBUG_KMS("Memory reserved for graphics device: %luK, 
> usable: %luK\n",
> +	DRM_DEBUG_KMS("Memory reserved for graphics device: %zuK, 
> usable: %luK\n",
>  		      dev_priv->gtt.stolen_size >> 10,
>  		      (dev_priv->gtt.stolen_size - reserved_total) 
> >> 10);
>  
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx