public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Dongwon Kim <dongwon.kim@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dw kim <dongwon.kim@intel.com>
Subject: [PATCH] fixing eu_mask value for BXT due to wrong bit mapping
Date: Fri, 11 Sep 2015 15:42:01 -0700	[thread overview]
Message-ID: <1442011321-12646-1-git-send-email-dongwon.kim@intel.com> (raw)

From: dw kim <dongwon.kim@intel.com>

Correct bit mapping of EUs in 'eu_disable' fuse register
for each subslice is (each word represents one subslice),

bit # 7   6   5   4   3   2   1   0
EU # 11  10   9   8   3   2   1   0

In BXT, each subslice has 6 EUs at most, which are EU0~EU2
and EU8~EU10 (EU11 and EU3 don't exist). Therefore, correct
eu_mask should be 0x77 to cover all EUs in each subslice that
can be possibly enabled.

Cc: Matthew D Roper <matthew.d.roper@intel.com>
Signed-off-by: dw kim <dongwon.kim@intel.com>
---
 drivers/gpu/drm/i915/i915_dma.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index 066a0ef..810f148 100644
--- a/drivers/gpu/drm/i915/i915_dma.c
+++ b/drivers/gpu/drm/i915/i915_dma.c
@@ -633,13 +633,21 @@ static void gen9_sseu_info_init(struct drm_device *dev)
 
 	/*
 	 * BXT has a single slice. BXT also has at most 6 EU per subslice,
-	 * and therefore only the lowest 6 bits of the 8-bit EU disable
-	 * fields are valid.
+	 * and bit mappings vs EU # in eu_disable fuse value in one subslice
+         * is like this;
+         *
+         *  Bit # 7   6   5   4   3   2   1   0
+         *  EU # 11  10   9   8   3   2   1   0
+         *
+         * Since only EUs with number "0, 1, 2, 8, 9, 10" are available in
+         * each subslice in BXT, bits in eu_mask should also be set according
+         * to this mapping, therefore, eu_mask = 0x77.
 	*/
+
 	if (IS_BROXTON(dev)) {
 		s_max = 1;
 		eu_max = 6;
-		eu_mask = 0x3f;
+		eu_mask = 0x77;
 	}
 
 	info = (struct intel_device_info *)&dev_priv->info;
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2015-09-11 22:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11 22:42 Dongwon Kim [this message]
2015-09-11 23:31 ` [PATCH] drm/i915: fixing eu_mask value for BXT due to wrong bit mapping (v2) Dongwon Kim
2015-09-14 11:06   ` Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442011321-12646-1-git-send-email-dongwon.kim@intel.com \
    --to=dongwon.kim@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox