From: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
To: "arun.siluvery@linux.intel.com" <arun.siluvery@linux.intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] intel: Adding missing Broxton PCI IDs.
Date: Fri, 18 Mar 2016 16:32:54 +0000 [thread overview]
Message-ID: <1458318761.3301.331.camel@intel.com> (raw)
In-Reply-To: <56EB4EDC.3030300@linux.intel.com>
On Fri, 2016-03-18 at 00:42 +0000, Arun Siluvery wrote:
> On 17/03/2016 21:39, Rodrigo Vivi wrote:
> > These IDs were already part of the kernel since:
> >
> > kernel commit 985dd4360fdf2533fe48a33a4a2094f2e4718dc0
> > Author: Imre Deak <imre.deak@intel.com>
> > Date: Thu Jan 28 16:04:12 2016 +0200
> >
> > drm/i915/bxt: update list of PCIIDs
> >
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> > lib/intel_chipset.h | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
> > index f3bd04f..4b40612 100644
> > --- a/lib/intel_chipset.h
> > +++ b/lib/intel_chipset.h
> > @@ -236,6 +236,8 @@ void intel_check_pch(void);
> > #define PCI_CHIP_BROXTON_0 0x0A84
> > #define PCI_CHIP_BROXTON_1 0x1A84
> > #define PCI_CHIP_BROXTON_2 0x5A84
> > +#define PCI_CHIP_BROXTON_3 0x1A85
> > +#define PCI_CHIP_BROXTON_4 0x5A85
> >
> > #endif /* __GTK_DOC_IGNORE__ */
> >
> > @@ -460,7 +462,9 @@ void intel_check_pch(void);
> >
> > #define IS_BROXTON(devid) ((devid) == PCI_CHIP_BROXTON_0
> > || \
> > (devid) == PCI_CHIP_BROXTON_1 ||
> > \
> > - (devid) == PCI_CHIP_BROXTON_2)
> > + (devid) == PCI_CHIP_BROXTON_2 ||
> > \
> > + (devid) == PCI_CHIP_BROXTON_3 ||
> > \
> > + (devid) == PCI_CHIP_BROXTON_4)
> >
> > #define IS_GEN9(devid) (IS_KABYLAKE(devid) || \
> > IS_SKYLAKE(devid) || \
> >
> I have recently added them to libdrm in android, would you also be
> adding them to libdrm?
I did libdrm one 2 weeks ago. It was reviewed and merged already.
>
> looks good to me,
> Reviewed-by: Arun Siluvery <arun.siluvery@linux.intel.com>
Thanks for the review. Patch merged.
>
> regards
> Arun
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-03-18 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 21:39 [PATCH i-g-t] intel: Adding missing Broxton PCI IDs Rodrigo Vivi
2016-03-18 0:42 ` Arun Siluvery
2016-03-18 16:32 ` Vivi, Rodrigo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458318761.3301.331.camel@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=arun.siluvery@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox