From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/ddi: Silence compiler warning for unknown output type
Date: Mon, 04 Apr 2016 09:20:27 +0300 [thread overview]
Message-ID: <1459750827.4618.2.camel@linux.intel.com> (raw)
In-Reply-To: <1459717154-27607-1-git-send-email-chris@chris-wilson.co.uk>
On su, 2016-04-03 at 21:59 +0100, Chris Wilson wrote:
> Silences
>
> src/drivers/gpu/drm/i915/intel_ddi.c: warning: 'port' may be used uninitialized in this function [-Wuninitialized]
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 766156f88ef4..921edf183d22 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -315,6 +315,9 @@ static void ddi_get_encoder_port(struct intel_encoder *intel_encoder,
> *dig_port = enc_to_mst(encoder)->primary;
> *port = (*dig_port)->port;
> break;
> + default:
> + WARN(1, "Invalid DDI encoder type %d\n", intel_encoder->type);
> + /* fallthrough and treat as unknown */
While touching it, might as well fix into MISSING_CASE. With that;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> case INTEL_OUTPUT_DISPLAYPORT:
> case INTEL_OUTPUT_EDP:
> case INTEL_OUTPUT_HDMI:
> @@ -326,9 +329,6 @@ static void ddi_get_encoder_port(struct intel_encoder *intel_encoder,
> *dig_port = NULL;
> *port = PORT_E;
> break;
> - default:
> - WARN(1, "Invalid DDI encoder type %d\n", intel_encoder->type);
> - break;
> }
> }
>
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-04 6:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 20:59 [PATCH] drm/i915/ddi: Silence compiler warning for unknown output type Chris Wilson
2016-04-04 6:20 ` Joonas Lahtinen [this message]
2016-04-04 7:25 ` Chris Wilson
2016-04-04 8:45 ` Jani Nikula
2016-04-04 9:00 ` Chris Wilson
2016-04-04 9:39 ` Joonas Lahtinen
2016-04-04 9:52 ` Jani Nikula
2016-04-04 6:57 ` ✓ Fi.CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459750827.4618.2.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox