From: ville.syrjala@linux.intel.com
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: [PATCH 4/5] drm/i915: Ask the sink whether training is required when exiting PSR main-link off mode
Date: Wed, 18 May 2016 21:34:21 +0300 [thread overview]
Message-ID: <1463596462-23372-5-git-send-email-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <1463596462-23372-1-git-send-email-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The sink can tell us if link training needs to be performed when
exiting PSR main-link off mode. Currently we get that information
from the VBT, but at least on my HSW the VBT says one thing, the sink
another. And in practice the sink doesn't seem to notice any screen
updates unless we do the training.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_psr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index 3d172b91a469..6cab66b1b26a 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -298,7 +298,8 @@ static void hsw_psr_enable_source(struct intel_dp *intel_dp)
else
val |= EDP_PSR_TP1_TP2_SEL;
- if (!dev_priv->vbt.psr.require_aux_wakeup)
+ if (!dev_priv->vbt.psr.require_aux_wakeup &&
+ !drm_dp_psr_need_train_on_exit(intel_dp->psr_dpcd))
val |= EDP_PSR_SKIP_AUX_EXIT;
I915_WRITE(EDP_PSR_CTL, val);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-05-18 18:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 18:34 [PATCH 0/5] drm/i915: Additional PSR stuff ville.syrjala
2016-05-18 18:34 ` [PATCH 1/5] drm/dp: Add drm_dp_psr_setup_time() ville.syrjala
2016-05-19 8:47 ` [PATCH v2 " ville.syrjala
2016-05-18 18:34 ` [PATCH 2/5] drm/i915: Check PSR setup time vs. vblank length ville.syrjala
2016-05-18 18:34 ` [PATCH 3/5] drm/dp: Add drm_dp_psr_need_train_on_exit() ville.syrjala
2016-05-18 18:34 ` ville.syrjala [this message]
2016-05-18 19:02 ` [PATCH 4/5] drm/i915: Ask the sink whether training is required when exiting PSR main-link off mode Daniel Vetter
2016-05-18 18:34 ` [PATCH 5/5] drm/i915: Move psr.link_standby setup to intel_psr_match_conditions() ville.syrjala
2016-05-18 19:04 ` Daniel Vetter
2016-05-19 5:30 ` ✗ Ro.CI.BAT: failure for drm/i915: Additional PSR stuff Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463596462-23372-5-git-send-email-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox