From: akash.goel@intel.com
To: intel-gfx@lists.freedesktop.org
Cc: sourab.gupta@intel.com, Akash Goel <akash.goel@intel.com>
Subject: [RFC 08/12] drm/i915: Store GuC ukernel logs in the local buffer
Date: Sat, 28 May 2016 01:12:59 +0530 [thread overview]
Message-ID: <1464378183-9433-9-git-send-email-akash.goel@intel.com> (raw)
In-Reply-To: <1464378183-9433-1-git-send-email-akash.goel@intel.com>
From: Akash Goel <akash.goel@intel.com>
This patch copies the content of GuC log buffer into the local buffer.
The data is written into local buffer in a circular manner, so 2 pointers
are maintained to track the data inside the buffer. And after copying the
logs, readers waiting for the data are woken up.
The data from the local buffer is supposed to be consumed by Userspace.
Signed-off-by: Akash Goel <akash.goel@intel.com>
---
drivers/gpu/drm/i915/i915_guc_submission.c | 27 +++++++++++++++++++++++++++
drivers/gpu/drm/i915/intel_guc.h | 3 +++
2 files changed, 30 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c
index 26b95e7..149826a 100644
--- a/drivers/gpu/drm/i915/i915_guc_submission.c
+++ b/drivers/gpu/drm/i915/i915_guc_submission.c
@@ -776,6 +776,11 @@ static void guc_move_to_next_buf(struct intel_guc *guc)
#ifdef CONFIG_DEBUG_FS
/* nothing to do here, all managed by relay */
return;
+#else
+ /* New log buffer produced, wake up the readers */
+ guc->log.next_seq++;
+ spin_unlock(&guc->log.buf_lock);
+ wake_up_interruptible_all(&guc->log.wq);
#endif
}
@@ -796,6 +801,27 @@ static void* guc_get_write_buffer(struct intel_guc *guc)
relay_reserve(guc->log_relay_chan, guc->log_obj->base.size);
return base_addr;
+#else
+ size_t n_subbufs, subbuf_size;
+ int next_index;
+
+ base_addr = guc->log.buf_obj->mapping;
+ if (!base_addr)
+ return NULL;
+
+ subbuf_size = guc->log_obj->base.size;
+ n_subbufs = guc->log.buf_obj->base.size / subbuf_size;
+
+ spin_lock(&guc->log.buf_lock);
+ next_index = guc->log.next_seq & (n_subbufs - 1);
+ /*
+ * If the logs are not being consumed fast enough, do not wait
+ * and overwrite the oldest data.
+ */
+ if ((guc->log.next_seq - guc->log.first_seq) >= n_subbufs)
+ guc->log.first_seq++;
+
+ return (base_addr + next_index * subbuf_size);
#endif
}
@@ -983,6 +1009,7 @@ static void guc_logging_init(struct intel_guc *guc)
void *vaddr;
spin_lock_init(&guc->log.buf_lock);
+ init_waitqueue_head(&guc->log.wq);
subbuf_size = guc->log_obj->base.size;
/* TODO: Decide based on the User's input */
diff --git a/drivers/gpu/drm/i915/intel_guc.h b/drivers/gpu/drm/i915/intel_guc.h
index 9e6ce2d..bdc3e63 100644
--- a/drivers/gpu/drm/i915/intel_guc.h
+++ b/drivers/gpu/drm/i915/intel_guc.h
@@ -124,6 +124,9 @@ struct intel_guc_fw {
struct intel_guc_log {
struct drm_i915_gem_object *buf_obj;
spinlock_t buf_lock;
+ wait_queue_head_t wq;
+ uint64_t first_seq;
+ uint64_t next_seq;
};
struct intel_guc {
--
1.9.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-27 19:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 19:42 [RFC 00/12] Support for sustained capturing of GuC firmware logs akash.goel
2016-05-27 19:42 ` [RFC 01/12] drm/i915: Decouple GuC log setup from verbosity parameter akash.goel
2016-05-27 19:42 ` [RFC 02/12] drm/i915: Add GuC ukernel logging related fields to fw interface file akash.goel
2016-05-27 19:42 ` [RFC 03/12] drm/i915: Support for GuC interrupts akash.goel
2016-05-27 19:43 ` Chris Wilson
2016-05-28 8:46 ` Goel, Akash
2016-05-27 19:56 ` Chris Wilson
2016-05-28 9:22 ` Goel, Akash
2016-05-28 12:13 ` Chris Wilson
2016-05-28 13:45 ` Goel, Akash
2016-05-28 14:35 ` Chris Wilson
2016-05-28 17:33 ` Goel, Akash
2016-05-27 19:42 ` [RFC 04/12] drm/i915: Handle log buffer flush interrupt event from GuC akash.goel
2016-05-27 19:42 ` [RFC 05/12] drm/i915: Add a relay backed debugfs interface for capturing GuC logs akash.goel
2016-05-27 19:42 ` [RFC 06/12] drm/i915: Store GuC ukernel logs in the relay buffer akash.goel
2016-05-27 19:42 ` [RFC 07/12] drm/i915: Allocate local buffer to store GuC ukernel logs akash.goel
2016-05-27 19:42 ` akash.goel [this message]
2016-05-27 19:43 ` [RFC 09/12] drm/i915: Add a char device file interface to capture " akash.goel
2016-05-27 19:48 ` Chris Wilson
2016-05-28 8:51 ` Goel, Akash
2016-05-27 19:43 ` [RFC 10/12] drm/i915: Support to capture GuC logs by multiple clients via device file iface akash.goel
2016-05-27 19:43 ` [RFC 11/12] drm/i915: Add sysfs interface to capture the GuC ukernel logs akash.goel
2016-05-27 19:43 ` [RFC 12/12] drm/i915: Forcefully flush GuC log buffer on reset akash.goel
2016-05-28 6:09 ` ✗ Ro.CI.BAT: failure for Support for sustained capturing of GuC firmware logs Patchwork
2016-06-02 10:16 ` [RFC 00/12] " Daniel Vetter
2016-06-02 10:21 ` Johannes Berg
2016-06-03 7:15 ` Daniel Vetter
2016-06-03 10:14 ` Goel, Akash
2016-06-03 10:20 ` Chris Wilson
2016-06-08 8:30 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464378183-9433-9-git-send-email-akash.goel@intel.com \
--to=akash.goel@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sourab.gupta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox