Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marius Vlad <marius.c.vlad@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t v2] tests/drm_lib.sh: Extract fake getopt options so it can sourced into tests that require it.
Date: Tue, 21 Jun 2016 15:34:07 +0300	[thread overview]
Message-ID: <1466512447-26513-1-git-send-email-marius.c.vlad@intel.com> (raw)
In-Reply-To: <1466504631-8304-1-git-send-email-marius.c.vlad@intel.com>

This should allow tests/vgem_reload_basic to pass check target and it
doesn't depend of i915 being present.

v2: Do not source drm_lib.sh, only fake getopt parsing
option to again access to --list-subtests option (Chris)

Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
CC: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/drm_getopt.sh     | 38 ++++++++++++++++++++++++++++++++++++++
 tests/drm_lib.sh        | 35 ++---------------------------------
 tests/vgem_reload_basic |  3 +++
 3 files changed, 43 insertions(+), 33 deletions(-)
 create mode 100644 tests/drm_getopt.sh

diff --git a/tests/drm_getopt.sh b/tests/drm_getopt.sh
new file mode 100644
index 0000000..a94a759
--- /dev/null
+++ b/tests/drm_getopt.sh
@@ -0,0 +1,38 @@
+# This is required for check/distcheck target as it has to --list-subtests
+# for each test. Source it if you add a new test in form of a (shell) script.
+
+# See tests/vgem_reload_basic
+
+IGT_EXIT_TIMEOUT=78
+IGT_EXIT_SKIP=77
+IGT_EXIT_SUCCESS=0
+IGT_EXIT_INVALID=79
+IGT_EXIT_FAILURE=99
+
+# hacked-up long option parsing
+for arg in $@ ; do
+	case $arg in
+		--list-subtests)
+			exit $IGT_EXIT_INVALID
+			;;
+		--run-subtest)
+			exit $IGT_EXIT_INVALID
+			;;
+		--debug)
+			IGT_LOG_LEVEL=debug
+			;;
+		--help-description)
+			echo $IGT_TEST_DESCRIPTION
+			exit $IGT_EXIT_SUCCESS
+			;;
+		--help)
+			echo "Usage: `basename $0` [OPTIONS]"
+			echo "  --list-subtests"
+			echo "  --run-subtest <pattern>"
+			echo "  --debug"
+			echo "  --help-description"
+			echo "  --help"
+			exit $IGT_EXIT_SUCCESS
+			;;
+	esac
+done
diff --git a/tests/drm_lib.sh b/tests/drm_lib.sh
index 2ba146b..c32bc68 100755
--- a/tests/drm_lib.sh
+++ b/tests/drm_lib.sh
@@ -1,38 +1,7 @@
 #!/bin/sh
 
-IGT_EXIT_TIMEOUT=78
-IGT_EXIT_SKIP=77
-IGT_EXIT_SUCCESS=0
-IGT_EXIT_INVALID=79
-IGT_EXIT_FAILURE=99
-
-# hacked-up long option parsing
-for arg in $@ ; do
-	case $arg in
-		--list-subtests)
-			exit $IGT_EXIT_INVALID
-			;;
-		--run-subtest)
-			exit $IGT_EXIT_INVALID
-			;;
-		--debug)
-			IGT_LOG_LEVEL=debug
-			;;
-		--help-description)
-			echo $IGT_TEST_DESCRIPTION
-			exit $IGT_EXIT_SUCCESS
-			;;
-		--help)
-			echo "Usage: `basename $0` [OPTIONS]"
-			echo "  --list-subtests"
-			echo "  --run-subtest <pattern>"
-			echo "  --debug"
-			echo "  --help-description"
-			echo "  --help"
-			exit $IGT_EXIT_SUCCESS
-			;;
-	esac
-done
+SOURCE_DIR="$( dirname "${BASH_SOURCE[0]}" )"
+. $SOURCE_DIR/drm_getopt.sh
 
 skip() {
 	echo "$@"
diff --git a/tests/vgem_reload_basic b/tests/vgem_reload_basic
index b150b2c..a42da70 100755
--- a/tests/vgem_reload_basic
+++ b/tests/vgem_reload_basic
@@ -5,6 +5,9 @@
 # ... we've broken this way too often :(
 #
 
+SOURCE_DIR="$( dirname "${BASH_SOURCE[0]}" )"
+. $SOURCE_DIR/drm_getopt.sh
+
 function unload() {
 	/sbin/rmmod vgem
 	# drm may be used by other devices (nouveau, radeon, udl, etc)
-- 
2.8.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-06-21 12:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 10:23 [PATCH i-g-t] tests/vgem_reload_basic: Include drm_lib.sh to please check target Marius Vlad
2016-06-21 10:33 ` Chris Wilson
2016-06-21 12:34 ` Marius Vlad [this message]
2016-06-21 12:42   ` [PATCH i-g-t v2] tests/drm_lib.sh: Extract fake getopt options so it can sourced into tests that require it Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466512447-26513-1-git-send-email-marius.c.vlad@intel.com \
    --to=marius.c.vlad@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox