From: Lyude <cpaul@redhat.com>
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
"open list:INTEL DRM DRIVERS excluding Poulsbo, Moorestow...,
linux-kernel@vger.kernel.org open list"
<dri-devel@lists.freedesktop.org>,
stable@vger.kernel.org, Daniel Vetter <daniel.vetter@intel.com>,
Lyude <cpaul@redhat.com>
Subject: [PATCH v3 0/4] Fixes for HPD
Date: Tue, 21 Jun 2016 13:00:24 -0400 [thread overview]
Message-ID: <1466528429-23136-1-git-send-email-cpaul@redhat.com> (raw)
This is a revised version of the patchset:
https://lists.freedesktop.org/archives/intel-gfx/2016-June/098787.html
This patchset is intended to fix the issue of not having HPD when we're in
runtime suspend, or on Valleyview/Cherryview systems when we don't have any
power wells enabled. While this isn't the best for RPM, until we have the
infrastructure to provide hpd while in runtime suspend this will have to
suffice since not having HPD at all times means a user could potentially boot
their system with no displays connected, then never have any displays they
connect afterwards get detected.
Unlike the previous patchset, this patchset includes a fix for the VGA detect
loops we were seeing on Valleyview. On my setup, this fix seems to have fixed
the loop entirely. As it turns out, I think our original understanding of this
issue wasn't entirely accurate. Originally it had been assumed that the HPD
signals we were getting from the ADPA were a result of turning the power wells
on and off. As it turns out, the HPD signals actually don't get fired off until
we do the force detect on the ADPA, not when we reset it. This means this
problem can easily be solved just by temporarily disabling HPD on the ADPA
whenever we do a force detect.
As such, "drm/i915/vlv: Disable HPD in valleyview_crt_detect_hotplug()"
deprecates Ville's previous two fixes
Cc: stable@vger.kernel.org
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Lyude (4):
drm/i915/vlv: Make intel_crt_reset() per-encoder
drm/i915/vlv: Reset the ADPA in vlv_display_power_well_init()
drm/i915/vlv: Disable HPD in valleyview_crt_detect_hotplug()
drm/i915: Enable polling when we don't have hpd
drivers/gpu/drm/i915/i915_drv.c | 7 +-
drivers/gpu/drm/i915/i915_drv.h | 6 ++
drivers/gpu/drm/i915/intel_crt.c | 28 ++++++--
drivers/gpu/drm/i915/intel_drv.h | 4 +-
drivers/gpu/drm/i915/intel_hotplug.c | 112 +++++++++++++++++++++++++++++---
drivers/gpu/drm/i915/intel_runtime_pm.c | 10 +++
6 files changed, 150 insertions(+), 17 deletions(-)
--
2.5.5
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2016-06-21 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 17:00 Lyude [this message]
2016-06-21 17:00 ` [PATCH v3 1/4] drm/i915/vlv: Make intel_crt_reset() per-encoder Lyude
2016-06-21 17:00 ` [PATCH v3 2/4] drm/i915/vlv: Reset the ADPA in vlv_display_power_well_init() Lyude
2016-06-21 17:00 ` [PATCH v3 3/4] drm/i915/vlv: Disable HPD in valleyview_crt_detect_hotplug() Lyude
2016-06-21 17:00 ` [PATCH v3 4/4] drm/i915: Enable polling when we don't have hpd Lyude
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466528429-23136-1-git-send-email-cpaul@redhat.com \
--to=cpaul@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox