From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: mesa-dev@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Add I915_PARAM_MMAP_GTT_VERSION to advertise unlimited mmaps
Date: Thu, 25 Aug 2016 11:00:54 +0300 [thread overview]
Message-ID: <1472112054.3589.2.camel@linux.intel.com> (raw)
In-Reply-To: <20160824194244.27583-1-chris@chris-wilson.co.uk>
On ke, 2016-08-24 at 20:42 +0100, Chris Wilson wrote:
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -355,6 +355,14 @@ static int i915_getparam(struct drm_device *dev, void *data,
> case I915_PARAM_MIN_EU_IN_POOL:
> value = INTEL_INFO(dev)->min_eu_in_pool;
> break;
> + case I915_PARAM_MMAP_GTT_VERSION:
> + /* 0 - Objects have to be smaller than aperture,
> + * all simultaneous users have to fit within the
> + * available space within the aperture.
> + * 1 - Objects can any size, and X,Y or untiled
> + */
> + value = 1;
The actual test would be if this function call succeeds, though.
value = 0 would never be returned, so I'm not sure it'll be useful to
document as such. So I might document as "Failure to execute the query
means..."
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-25 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 19:42 [PATCH] drm/i915: Add I915_PARAM_MMAP_GTT_VERSION to advertise unlimited mmaps Chris Wilson
2016-08-24 19:42 ` [PATCH] i965: Embrace "unlimited" GTT mmap support Chris Wilson
2016-08-25 7:06 ` [Mesa-dev] " Daniel Vetter
2016-08-25 7:26 ` Kenneth Graunke
2016-08-25 20:43 ` Ian Romanick
2016-08-25 21:58 ` Chris Wilson
2016-08-25 7:02 ` [PATCH] drm/i915: Add I915_PARAM_MMAP_GTT_VERSION to advertise unlimited mmaps Daniel Vetter
2016-08-25 8:00 ` Joonas Lahtinen [this message]
2016-08-25 8:27 ` [Intel-gfx] " Chris Wilson
2016-08-25 12:15 ` Joonas Lahtinen
2016-08-25 18:05 ` [PATCH v2] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472112054.3589.2.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mesa-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox