From: John Harrison <john.c.harrison@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
<Intel-GFX@Lists.FreeDesktop.Org>
Cc: DRI-Devel@Lists.FreeDesktop.Org
Subject: Re: [Intel-gfx] [PATCH v4 1/7] drm/i915: Fix request locking during error capture & debugfs dump
Date: Wed, 25 Jan 2023 14:04:30 -0800 [thread overview]
Message-ID: <147f4a46-7349-3158-5799-1643bfdf13a6@intel.com> (raw)
In-Reply-To: <fd011cd7-7212-ff77-0e1d-56cdc1372e3a@linux.intel.com>
On 1/23/2023 09:51, Tvrtko Ursulin wrote:
> On 20/01/2023 23:28, John.C.Harrison@Intel.com wrote:
>> From: John Harrison <John.C.Harrison@Intel.com>
>>
>> <snip>
>>
>> -struct i915_request *intel_context_find_active_request(struct
>> intel_context *ce)
>> +struct i915_request *intel_context_find_active_request_get(struct
>> intel_context *ce)
>
> TBH I don't "dig" this name, it's a bit on the long side and feels out
> of character. I won't insist it be changed, but if get really has to
> be included in the name I would be happy with
> intel_context_get_active_request().
Daniele sided with you on this one. Will use your naming.
John.
next prev parent reply other threads:[~2023-01-25 22:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 23:28 [Intel-gfx] [PATCH v4 0/7] Allow error capture without a request & fix locking issues John.C.Harrison
2023-01-20 23:28 ` [Intel-gfx] [PATCH v4 1/7] drm/i915: Fix request locking during error capture & debugfs dump John.C.Harrison
2023-01-23 17:51 ` Tvrtko Ursulin
2023-01-23 20:35 ` John Harrison
2023-01-25 22:04 ` John Harrison [this message]
2023-01-20 23:28 ` [Intel-gfx] [PATCH v4 2/7] drm/i915: Fix up locking around dumping requests lists John.C.Harrison
2023-01-20 23:40 ` John Harrison
2023-01-24 14:40 ` Tvrtko Ursulin
2023-01-25 18:00 ` John Harrison
2023-01-25 18:12 ` Tvrtko Ursulin
2023-01-25 18:17 ` John Harrison
2023-01-25 0:31 ` Ceraolo Spurio, Daniele
2023-01-20 23:28 ` [Intel-gfx] [PATCH v4 3/7] drm/i915: Allow error capture without a request John.C.Harrison
2023-01-25 0:39 ` Ceraolo Spurio, Daniele
2023-01-25 0:56 ` John Harrison
2023-01-20 23:28 ` [Intel-gfx] [PATCH v4 4/7] drm/i915: Allow error capture of a pending request John.C.Harrison
2023-01-20 23:28 ` [Intel-gfx] [PATCH v4 5/7] drm/i915/guc: Look for a guilty context when an engine reset fails John.C.Harrison
2023-01-20 23:28 ` [Intel-gfx] [PATCH v4 6/7] drm/i915/guc: Add a debug print on GuC triggered reset John.C.Harrison
2023-01-20 23:28 ` [Intel-gfx] [PATCH v4 7/7] drm/i915/guc: Rename GuC register state capture node to be more obvious John.C.Harrison
2023-01-25 0:44 ` Ceraolo Spurio, Daniele
2023-01-20 23:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Allow error capture without a request & fix locking issues (rev2) Patchwork
2023-01-21 21:41 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=147f4a46-7349-3158-5799-1643bfdf13a6@intel.com \
--to=john.c.harrison@intel.com \
--cc=DRI-Devel@Lists.FreeDesktop.Org \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox