From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Handle validation of relocation object with length >=2GB
Date: Mon, 13 Feb 2017 14:25:29 +0200 [thread overview]
Message-ID: <1486988729.3223.31.camel@linux.intel.com> (raw)
In-Reply-To: <20170213110220.GE30915@nuc-i3427.alporthouse.com>
On ma, 2017-02-13 at 11:02 +0000, Chris Wilson wrote:
> On Mon, Feb 13, 2017 at 12:58:57PM +0200, Joonas Lahtinen wrote:
> >
> > On ma, 2017-02-13 at 12:14 +0530, Sagar Arun Kamble wrote:
> > >
> > > From: "sagar.a.kamble@intel.com" <sagar.a.kamble@intel.com>
> > >
> > > With prefaulting extended to support >=2GB, i915 can handle
> > > relocation objects >=2GB. type conversion of length from int to
> > > unsigned long in access_ok was making the validation bail out with
> > > -EFAULT.
> > >
> > > Testcase: igt/gem_exec_reloc/wc-31
> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> >
> > With the correct "From:" and with "size_t" as type, this is;
> >
> > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> My earlier comments still apply in that this is not how I fixed this
> years ago, and I still much prefer my fix.
Where are the earlier comments? I must have missed them.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-13 12:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 6:44 [PATCH 1/2] mm: Handle prefault for size >= 2GB Sagar Arun Kamble
2017-02-13 6:44 ` [PATCH 2/2] drm/i915: Handle validation of relocation object with length >=2GB Sagar Arun Kamble
2017-02-13 10:58 ` Joonas Lahtinen
2017-02-13 11:02 ` Chris Wilson
2017-02-13 12:25 ` Joonas Lahtinen [this message]
2017-02-13 12:33 ` Chris Wilson
2017-02-13 16:05 ` Kamble, Sagar A
2017-02-13 7:21 ` ✓ Fi.CI.BAT: success for series starting with [1/2] mm: Handle prefault for size >= 2GB Patchwork
2017-02-13 10:48 ` [PATCH 1/2] " Joonas Lahtinen
2017-02-13 10:58 ` Joonas Lahtinen
2017-02-13 15:53 ` Kamble, Sagar A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486988729.3223.31.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox