Re: [PATCH i-g-t 2/2] tests/chamelium: Don't sleep so much in basic hpd tests

[Lyude Paul <lyude@redhat.com>]

On Thu, 2017-02-23 at 07:26 +0000, Chris Wilson wrote:
> On Wed, Feb 22, 2017 at 10:18:33PM -0500, Lyude wrote:
> > Now that we can just disable HPD storm detection, there's no need
> > to
> > sleep between each hotplug cycle.
> > 
> > Signed-off-by: Lyude <lyude@redhat.com>
> > ---
> >  tests/chamelium.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/tests/chamelium.c b/tests/chamelium.c
> > index 849e1ac..810c955 100644
> > --- a/tests/chamelium.c
> > +++ b/tests/chamelium.c
> > @@ -154,6 +154,7 @@ test_basic_hotplug(data_t *data, struct
> > chamelium_port *port)
> >  	int i;
> >  
> >  	reset_state(data, port);
> > +	igt_hpd_storm_set_threshold(0);
> 
> You will want to check that you have the debugfs interface first and
> skip the test otherwise. Or was there a fallback? Or is it already
> checkd?
> 
> -Chris
If the debugfs interface isn't there, the function just doesn't do
anything and returns immediately

> 
-- 
Cheers,
	Lyude
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx