Re: [PATCH] i915/HuC: Add an extra check for platforms that do not have HUC

From: Ander Conselvan De Oliveira <conselvan2@gmail.com>
To: Anusha Srivatsa <anusha.srivatsa@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@itel.com>
Subject: Re: [PATCH] i915/HuC: Add an extra check for platforms that do not have HUC
Date: Thu, 02 Mar 2017 16:14:23 +0200	[thread overview]
Message-ID: <1488464063.3654.3.camel@gmail.com> (raw)
In-Reply-To: <1488398335-13121-1-git-send-email-anusha.srivatsa@intel.com>

On Wed, 2017-03-01 at 11:58 -0800, Anusha Srivatsa wrote:
> Return silently without producing much noise on platforms
> that have a HuC but the firmware is absent.

Matches what's done for GuC.

Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>

> Cc: Ander Conselvan De Oliveira <ander.conselvan.de.oliveira@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@itel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_huc.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_huc.c b/drivers/gpu/drm/i915/intel_huc.c
> index c28543d..e660109 100644
> --- a/drivers/gpu/drm/i915/intel_huc.c
> +++ b/drivers/gpu/drm/i915/intel_huc.c
> @@ -181,12 +181,14 @@ void intel_huc_init(struct drm_i915_private *dev_priv)
>  	}
>  
>  	huc_fw->path = fw_path;
> +
> +	if (huc_fw->path == NULL)
> +		return;
> +
>  	huc_fw->fetch_status = INTEL_UC_FIRMWARE_PENDING;
>  
>  	DRM_DEBUG_DRIVER("HuC firmware pending, path %s\n", fw_path);
>  
> -	WARN(huc_fw->path == NULL, "HuC present but no fw path\n");
> -
>  	intel_uc_fw_fetch(dev_priv, huc_fw);
>  }
>  
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx