Re: [PATCH] drm/i915: make a few DDI functions static

[Paulo Zanoni <paulo.r.zanoni@intel.com>]

Em Sex, 2017-03-31 às 13:21 +0300, Ville Syrjälä escreveu:
> On Thu, Mar 30, 2017 at 05:57:52PM -0300, Paulo Zanoni wrote:
> > 
> > We don't need to export them since they're not being used outside
> > the
> > file. The next time I try to find the callers for these things I
> > will
> > know I won't need to look outside intel_ddi.c.
> 
> You don't do cscope/ctags/whatever?

When a function is static I just put the vim cursor on top of its name
and press * and go with n/N. I think that's always faster than any
other method. But yeah, for non-static stuff I end up having to use
better tools.

> 
> But anyway static is good since it hands the compiler a bit more
> rope.
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thanks!

> 
> > 
> > 
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_ddi.c | 8 ++++----
> >  drivers/gpu/drm/i915/intel_drv.h | 4 ----
> >  2 files changed, 4 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> > b/drivers/gpu/drm/i915/intel_ddi.c
> > index 83abab9..0914ad9 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -539,7 +539,7 @@ intel_ddi_get_buf_trans_fdi(struct
> > drm_i915_private *dev_priv,
> >   * values in advance. This function programs the correct values
> > for
> >   * DP/eDP/FDI use cases.
> >   */
> > -void intel_prepare_dp_ddi_buffers(struct intel_encoder *encoder)
> > +static void intel_prepare_dp_ddi_buffers(struct intel_encoder
> > *encoder)
> >  {
> >  	struct drm_i915_private *dev_priv = to_i915(encoder-
> > >base.dev);
> >  	u32 iboost_bit = 0;
> > @@ -806,7 +806,7 @@ void hsw_fdi_link_train(struct intel_crtc
> > *crtc,
> >  		   DP_TP_CTL_ENABLE);
> >  }
> >  
> > -void intel_ddi_init_dp_buf_reg(struct intel_encoder *encoder)
> > +static void intel_ddi_init_dp_buf_reg(struct intel_encoder
> > *encoder)
> >  {
> >  	struct intel_dp *intel_dp = enc_to_intel_dp(&encoder-
> > >base);
> >  	struct intel_digital_port *intel_dig_port =
> > @@ -1616,8 +1616,8 @@ uint32_t ddi_signal_levels(struct intel_dp
> > *intel_dp)
> >  	return DDI_BUF_TRANS_SELECT(level);
> >  }
> >  
> > -void intel_ddi_clk_select(struct intel_encoder *encoder,
> > -			  struct intel_shared_dpll *pll)
> > +static void intel_ddi_clk_select(struct intel_encoder *encoder,
> > +				 struct intel_shared_dpll *pll)
> >  {
> >  	struct drm_i915_private *dev_priv = to_i915(encoder-
> > >base.dev);
> >  	enum port port = intel_ddi_get_encoder_port(encoder);
> > diff --git a/drivers/gpu/drm/i915/intel_drv.h
> > b/drivers/gpu/drm/i915/intel_drv.h
> > index e24641b..313fad0 100644
> > --- a/drivers/gpu/drm/i915/intel_drv.h
> > +++ b/drivers/gpu/drm/i915/intel_drv.h
> > @@ -1229,12 +1229,9 @@ void intel_crt_init(struct drm_i915_private
> > *dev_priv);
> >  void intel_crt_reset(struct drm_encoder *encoder);
> >  
> >  /* intel_ddi.c */
> > -void intel_ddi_clk_select(struct intel_encoder *encoder,
> > -			  struct intel_shared_dpll *pll);
> >  void intel_ddi_fdi_post_disable(struct intel_encoder
> > *intel_encoder,
> >  				struct intel_crtc_state
> > *old_crtc_state,
> >  				struct drm_connector_state
> > *old_conn_state);
> > -void intel_prepare_dp_ddi_buffers(struct intel_encoder *encoder);
> >  void hsw_fdi_link_train(struct intel_crtc *crtc,
> >  			const struct intel_crtc_state
> > *crtc_state);
> >  void intel_ddi_init(struct drm_i915_private *dev_priv, enum port
> > port);
> > @@ -1255,7 +1252,6 @@ bool intel_ddi_is_audio_enabled(struct
> > drm_i915_private *dev_priv,
> >  void intel_ddi_get_config(struct intel_encoder *encoder,
> >  			  struct intel_crtc_state *pipe_config);
> >  
> > -void intel_ddi_init_dp_buf_reg(struct intel_encoder *encoder);
> >  void intel_ddi_clock_get(struct intel_encoder *encoder,
> >  			 struct intel_crtc_state *pipe_config);
> >  void intel_ddi_set_vc_payload_alloc(const struct intel_crtc_state
> > *crtc_state,
> > -- 
> > 2.7.4
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx