From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 1/5] drm/i915: Mark up clflushes as belonging to an unordered timeline
Date: Mon, 10 Apr 2017 13:17:20 +0300 [thread overview]
Message-ID: <1491819440.3364.1.camel@linux.intel.com> (raw)
In-Reply-To: <20170410085557.14203-1-chris@chris-wilson.co.uk>
On ma, 2017-04-10 at 09:55 +0100, Chris Wilson wrote:
> 2 clflushes on two different objects are not ordered, and so do not
> belong to the same timeline (context). Either we use a unique context
> for each, or we reserve a special global context to mean unordered.
> Ideally, we would reserve 0 to mean unordered (DMA_FENCE_NO_CONTEXT) to
> have the same semantics everywhere.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
<SNIP>
> @@ -157,7 +156,7 @@ void i915_gem_clflush_object(struct drm_i915_gem_object *obj,
> dma_fence_init(&clflush->dma,
> &i915_clflush_ops,
> &clflush_lock,
> - clflush_context,
> + to_i915(obj->base.dev)->mm.unordered_timeline,
It seems you have high confidence on being able to replace this line
with DMA_FENCE_NO_CONTEXT ;)
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-04-10 10:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 8:55 [PATCH 1/5] drm/i915: Mark up clflushes as belonging to an unordered timeline Chris Wilson
2017-04-10 8:55 ` [PATCH 2/5] drm/i915: Lift timeline ordering to await_dma_fence Chris Wilson
2017-04-10 10:21 ` Joonas Lahtinen
2017-04-10 8:55 ` [PATCH 3/5] drm/i915: Make ptr_unpack_bits() more function-like Chris Wilson
2017-04-10 8:55 ` [PATCH 4/5] drm/i915: Redefine ptr_pack_bits() and friends Chris Wilson
2017-04-10 8:55 ` [PATCH 5/5] drm/i915: Squash repeated awaits on the same fence Chris Wilson
2017-04-10 9:27 ` ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Mark up clflushes as belonging to an unordered timeline Patchwork
2017-04-10 10:17 ` Joonas Lahtinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491819440.3364.1.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox