From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/guc: write wopcm related register once during uc init
Date: Thu, 13 Apr 2017 13:59:04 +0300 [thread overview]
Message-ID: <1492081144.2965.13.camel@linux.intel.com> (raw)
In-Reply-To: <1491524332-23860-1-git-send-email-daniele.ceraolospurio@intel.com>
On to, 2017-04-06 at 17:18 -0700, Daniele Ceraolo Spurio wrote:
> The wopcm registers are write-once, so any write after the first one
> will just be ignored. The registers survive a GPU reset but not
> always a suspend/resume cycle, so to keep things simple keep the
> writes in the intel_uc_init_hw function instead of moving it earlier
> to make sure we attempt them every time we try to load GuC.
>
> Cc: Jeff McGee <jeff.mcgee@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
This is an improvement, so:
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To be exact, shouldn't we read the value and see if it has been written
previously (bit 1). i915 module can be removed and added multiple
times.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-04-13 10:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 0:18 [PATCH] drm/i915/guc: write wopcm related register once during uc init Daniele Ceraolo Spurio
2017-04-07 0:39 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-04-13 11:02 ` Joonas Lahtinen
2017-04-13 11:15 ` Joonas Lahtinen
2017-04-13 10:59 ` Joonas Lahtinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492081144.2965.13.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox