From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Oscar Mateo <oscar.mateo@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [RFC] drm/i915: Allow the UMD to configure their own power clock state
Date: Wed, 10 May 2017 15:59:03 +0300 [thread overview]
Message-ID: <1494421143.6362.33.camel@linux.intel.com> (raw)
In-Reply-To: <1493737674-5282-1-git-send-email-oscar.mateo@intel.com>
On ti, 2017-05-02 at 15:07 +0000, Oscar Mateo wrote:
> This allows userspace to shutdown slices at will for performance/power reasons
> (because it doesn't have a use for more slices).
>
> Cc: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Oscar Mateo <oscar.mateo@intel.com>
<SNIP>
> @@ -673,6 +674,11 @@ static int gen8_init_workarounds(struct intel_engine_cs *engine)
> GEN6_WIZ_HASHING_MASK,
> GEN6_WIZ_HASHING_16x4);
>
> + /* Allow the UMD to configure their own power clock state */
> + ret = wa_ring_whitelist_reg(engine, GEN8_R_PWR_CLK_STATE);
> + if (ret)
> + return ret;
> +
> return 0;
> }
>
> @@ -841,6 +847,11 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
> if (ret)
> return ret;
>
> + /* Allow the UMD to configure their own power clock state */
> + ret = wa_ring_whitelist_reg(engine, GEN8_R_PWR_CLK_STATE);
> + if (ret)
> + return ret;
This is not a workaround, so it should be part of the cmd parser and
have an userspace.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-10 12:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 15:07 [RFC] drm/i915: Allow the UMD to configure their own power clock state Oscar Mateo
2017-05-02 22:24 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-05-10 12:59 ` Joonas Lahtinen [this message]
2017-05-10 13:28 ` [RFC] " Daniel Vetter
2017-05-10 8:33 ` Oscar Mateo
2017-05-11 13:09 ` Joonas Lahtinen
2017-05-10 13:47 ` Mika Kuoppala
2017-05-10 14:09 ` Michał Winiarski
2017-05-10 8:29 ` Oscar Mateo
2017-05-10 14:26 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494421143.6362.33.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=oscar.mateo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox